[18.0][MIG] l10n_eu_product_adr: Migration to 18.0 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
4 times, most recently
from
7b6dc21
to
0c9c60f
Compare
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
0c9c60f
to
3dccc14
Compare
mmequignon
reviewed
Oct 15, 2024
| @@ -19,24 +19,18 @@ | |||
| name="adr" | |||
| string="Dangerous Goods" | |||
| groups="l10n_eu_product_adr.group_adr_goods_user" | |||
| attrs="{'invisible': ['|', ('type', '!=', 'product'), '&', ('is_dangerous', '=', False), ('adr_goods_on_variants', '=', False)]}" | |||
| invisible="not (is_storable and (is_dangerous or adr_goods_on_variants))" | |||
There was a problem hiding this comment.
are we sure this is the same ?
I would have written this not is_storable or (is_dangerous and adr_goods_on_variants)
There was a problem hiding this comment.
no, it will be: not is_storable or (not is_dangerous and not adr_goods_on_variants)
There was a problem hiding this comment.
Thanks for the change it looks better IMO
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
2 times, most recently
from
94b6550
to
8a6ce61
Compare
TDu
reviewed
Oct 18, 2024
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
8a6ce61
to
7d47552
Compare
Hi @TDu ,I have checked the differences between PR 16.0 and branch 14.0. The PR 16.0 had incorrect group permissions. I have updated. thank you |
chaule97
changed the title
Currently translated at 80.3% (98 of 122 strings) Translation: community-data-files-13.0/community-data-files-13.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-13-0/community-data-files-13-0-l10n_eu_product_adr/nl/
Currently translated at 81.1% (99 of 122 strings) Translation: community-data-files-13.0/community-data-files-13.0-l10n_eu_product_adr Translate-URL: https://translation.odoo-community.org/projects/community-data-files-13-0/community-data-files-13-0-l10n_eu_product_adr/nl/
Co-authored-by: Iryna Vyshnevska <iryna.vyshnevska@camptocamp.com>
chaule97
force-pushed
the
18.0-mig-l10n_eu_product_adr
branch
from
7d47552
to
f5dfe98
Compare
TDu
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_06_product_variant_migrationbecause there is no more pre-migration in Odoo 16+._compute_display_namemethod inAdrClassandAdrGoodsbecause thename_searchmethod in Odoo 18 has changed and usedisplay_namevalue to return result.