[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx #637

TheMule71 · 2022-07-21T16:17:18Z

Extend report xlsx to export directly to pdf.

andreampiovesana

ok

andreampiovesana · 2022-07-21T18:51:20Z

add in manifest
"external_dependencies": {
"python": ["xlsxwriter"],
"deb": ["libreoffice"],
},

scigghia · 2022-07-22T06:23:19Z

why this error in runboat?

++ oca_list_external_dependencies deb

DEBIAN_FRONTEND=noninteractive
apt-get install -qq --no-install-recommends default-jre-headless graphviz libreoffice
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/p/python3.8/libpython3.8_3.8.10-0ubuntu1~20.04.4_amd64.deb 404 Not Found [IP: 185.125.190.36 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

however for me it is ok

primes2h · 2022-07-22T08:32:11Z

report_xlsx_pdf/readme/INSTALL.rst

+
+For testing it is also necessary ``xlrd`` Python module installed::
+
+$ pip3 install xlrd


I would add libreoffice installed as a requirement as well (only on Linux systems for now).

primes2h · 2022-07-22T08:37:28Z

report_xlsx_pdf/models/ir_report.py

+    _inherit = "ir.actions.report"
+
+    report_xlsx_to_pdf = fields.Boolean(
+        string="Report xlsx to pdf",


Suggested change

string="Report xlsx to pdf",

string="Export to pdf format",

primes2h · 2022-07-22T08:47:01Z

report_xlsx_pdf/__manifest__.py

+    "name": "Extend report xlsx to export directly to pdf",
+    "summary": "Extend report xlsx to export directly to pdf",


Suggested change

"name": "Extend report xlsx to export directly to pdf",

"summary": "Extend report xlsx to export directly to pdf",

"name": "Export xlsx report to pdf",

"summary": "Extend report_xlsx to export directly to pdf",

primes2h · 2022-07-22T08:52:17Z

report_xlsx_pdf/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+This module extend xlsx report to convert in pdf using libreoffice


Suggested change

This module extend xlsx report to convert in pdf using libreoffice

This module extend ``report_xlsx`` to convert xlsx to pdf using libreoffice.

TheMule71 · 2022-07-26T17:07:40Z

why this error in runboat?

++ oca_list_external_dependencies deb

DEBIAN_FRONTEND=noninteractive

apt-get install -qq --no-install-recommends default-jre-headless graphviz libreoffice
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/p/python3.8/libpython3.8_3.8.10-0ubuntu1~20.04.4_amd64.deb 404 Not Found [IP: 185.125.190.36 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

however for me it is ok

I'm at loss here. It's looking for the wrong file, the correct link is:

http://security.ubuntu.com/ubuntu/pool/main/p/python3.8/libpython3.8_3.8.10-0ubuntu1~20.04.5_amd64.deb

not

http://security.ubuntu.com/ubuntu/pool/main/p/python3.8/libpython3.8_3.8.10-0ubuntu1~20.04.4_amd64.deb

but I'm not sure how to fix it.

@sbidoul (sorry to bother you)
Maybe do an apt-get update
before this apt-get install here?
https://github.com/OCA/oca-ci/blob/cffeb8853b2833c5a47da3200b4e3025b47de043/bin/oca_install_addons#L28

I might be completely off track, tho. I've never looked at those scripts before.

primes2h · 2022-07-27T08:40:41Z

@TheMule71
Please mark PR as ready for review.

TheMule71 · 2022-07-27T11:37:58Z

@TheMule71 Please mark PR as ready for review.

OK, but tests are still failing.

sbidoul · 2022-07-27T11:41:41Z

Maybe do an apt-get update before this apt-get install here?

@TheMule71 yes that's what we need to do. There is an open issue for that in oca/oca-ci (OCA/oca-ci#26). Would you like to do a PR for that ?

etobella · 2022-07-28T07:44:48Z

Now it is green and ready to review 😄

TheMule71 · 2022-07-28T08:25:15Z

Now it is green and ready to review smile

Thanks!

Maybe do an apt-get update before this apt-get install here?

@TheMule71 yes that's what we need to do. There is an open issue for that in oca/oca-ci (OCA/oca-ci#26). Would you like to do a PR for that ?

Looks like @etobella beat me to that. :)

primes2h

LGTM

Thanks!

andreampiovesana · 2022-08-23T09:21:36Z

merge?

etobella

Readme is not complete.

Tests are for report_xlsx, can you test the transformation?

report_xlsx_pdf/readme/USAGE.rst

etobella · 2022-08-27T20:09:33Z

report_xlsx_pdf/readme/INSTALL.rst

@@ -0,0 +1,10 @@
+Make sure you have ``xlsxwriter`` Python module installed::


This comes from report_xlsx, so it is probably not needed here. The only thing needed is libreoffice in this case, as xlsxwriter comes from report_xlsx

etobella · 2022-08-27T20:12:42Z

report_xlsx_pdf/tests/test_report.py

+            active_model="res.partner"
+        )
+        self.report_name = "report_xlsx.partner_xlsx"
+        self.report_xlsx_to_pdf = True


I don't understand this. It is never used... You never tested that is is transformed. This test is for report_xlsx standard. Can you test the code from this module?

self.report_xlsx_to_pdf = True
is the new parameter for this app

But you are editing self, in this case, the TestClass, it does not make sense. You should do self.xlsx_report.report_xlsx_to_pdf = True

@andreampiovesana can you attend this comment? Thanks!

andreampiovesana · 2022-08-29T07:15:56Z

for new merge of PR #628
you shoud change

andreampiovesana · 2022-09-29T13:18:01Z

merge?

francesco-ooops · 2022-09-29T13:21:04Z

merge?

@andreampiovesana have @etobella 's remarks been addressed?

andreampiovesana · 2022-10-11T08:46:07Z

self.report_xlsx_to_pdf = True is the specific parameter right? Il giorno sab 27 ago 2022 alle ore 22:13 Enric Tobella < ***@***.***> ha scritto:

…

***@***.**** requested changes on this pull request. Readme is not complete. Tests are for report_xlsx, can you test the transformation? ------------------------------ In report_xlsx_pdf/readme/USAGE.rst <#637 (comment)>: > @@ -0,0 +1,31 @@ +An example of XLSX report for partners on a module called `module_name`: This usage comes from report_xlsx it is probably not needed, isn't it? The real usage is showing how the flag is used, Can you change it? ------------------------------ In report_xlsx_pdf/readme/INSTALL.rst <#637 (comment)>: > @@ -0,0 +1,10 @@ +Make sure you have ``xlsxwriter`` Python module installed:: This comes from report_xlsx, so it is probably not needed here. The only thing needed is libreoffice in this case, as xlsxwriter comes from report_xlsx ------------------------------ In report_xlsx_pdf/tests/test_report.py <#637 (comment)>: > + +try: + from xlrd import open_workbook +except ImportError: + _logger.debug("Can not import xlrd`.") + + +class TestReport(common.TransactionCase): + def setUp(self): + super(TestReport, self).setUp() + report_object = self.env["ir.actions.report"] + self.xlsx_report = self.env["report.report_xlsx.abstract"].with_context( + active_model="res.partner" + ) + self.report_name = "report_xlsx.partner_xlsx" + self.report_xlsx_to_pdf = True I don't understand this. It is never used... You never tested that is is transformed. This test is for report_xlsx standard. Can you test the code from this module? — Reply to this email directly, view it on GitHub <#637 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKOJA4KGUMTTVUYVAO24CTV3JZGVANCNFSM54IHGR5A> . You are receiving this because you commented.Message ID: ***@***.***>

andreampiovesana · 2022-11-11T09:15:14Z

@OCA/reporting-engine-maintainers we use this app in production and this fix many situations where print in qweb-pdf take too much time to export, specially with report with hundreds of pages and we use the same technology of py3o.
Please can you merge?

github-actions · 2023-03-12T12:26:12Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

HviorForgeFlow · 2023-03-13T07:51:02Z

ping @etobella

github-actions · 2023-07-23T12:23:56Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

etobella · 2023-08-27T15:40:13Z

Reopening, as the necessary change is minimal. Can you review it @TheMule71 @andreampiovesana

github-actions · 2024-01-07T12:24:01Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

HviorForgeFlow

Minor changes required, after that, it can be merged :)

HviorForgeFlow · 2024-01-08T10:22:50Z

report_xlsx_pdf/tests/test_report.py

+            active_model="res.partner"
+        )
+        self.report_name = "report_xlsx.partner_xlsx"
+        self.report_xlsx_to_pdf = True


@andreampiovesana can you attend this comment? Thanks!

HviorForgeFlow · 2024-01-08T10:23:18Z

report_xlsx_pdf/__manifest__.py

+{
+    "name": "Export xlsx report to pdf",
+    "summary": "Extend report_xlsx to export directly to pdf",
+    "author": "Openindustry.it," "Odoo Community Association (OCA)",


Suggested change

"author": "Openindustry.it," "Odoo Community Association (OCA)",

"author": "Openindustry.it, Odoo Community Association (OCA)",

andreampiovesana approved these changes Jul 21, 2022

View reviewed changes

TheMule71 force-pushed the 14.0-imp-report_xlsx_pdf_module branch from f680c05 to 94b7689 Compare July 21, 2022 19:13

scigghia approved these changes Jul 22, 2022

View reviewed changes

OCA-git-bot added the approved label Jul 22, 2022

primes2h suggested changes Jul 22, 2022

View reviewed changes

OCA-git-bot removed the approved label Jul 22, 2022

marcelofrare approved these changes Jul 24, 2022

View reviewed changes

TheMule71 force-pushed the 14.0-imp-report_xlsx_pdf_module branch from 94b7689 to 634cd7e Compare July 26, 2022 16:46

TheMule71 requested a review from primes2h July 26, 2022 17:07

TheMule71 marked this pull request as ready for review July 27, 2022 11:38

francescapenso approved these changes Jul 28, 2022

View reviewed changes

primes2h approved these changes Jul 28, 2022

View reviewed changes

OCA-git-bot added the approved label Jul 28, 2022

etobella requested changes Aug 27, 2022

View reviewed changes

OCA-git-bot removed the approved label Aug 27, 2022

[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx

ea5a63a

TheMule71 force-pushed the 14.0-imp-report_xlsx_pdf_module branch from 634cd7e to ea5a63a Compare September 2, 2022 09:58

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 12, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 19, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023

github-actions bot closed this Aug 27, 2023

etobella reopened this Aug 27, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024

HviorForgeFlow requested changes Jan 8, 2024

View reviewed changes

github-actions bot closed this Feb 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx #637

[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx #637

TheMule71 commented Jul 21, 2022

andreampiovesana left a comment

andreampiovesana commented Jul 21, 2022

scigghia commented Jul 22, 2022

primes2h Jul 22, 2022

primes2h Jul 22, 2022

primes2h Jul 22, 2022

primes2h Jul 22, 2022

TheMule71 commented Jul 26, 2022

primes2h commented Jul 27, 2022

TheMule71 commented Jul 27, 2022

sbidoul commented Jul 27, 2022 •

edited

Loading

etobella commented Jul 28, 2022

TheMule71 commented Jul 28, 2022

primes2h left a comment

andreampiovesana commented Aug 23, 2022

etobella left a comment

etobella Aug 27, 2022

etobella Aug 27, 2022

andreampiovesana Aug 29, 2022

etobella Aug 27, 2023 •

edited

Loading

HviorForgeFlow Jan 8, 2024

andreampiovesana commented Aug 29, 2022

andreampiovesana commented Sep 29, 2022

francesco-ooops commented Sep 29, 2022

andreampiovesana commented Oct 11, 2022 via email

andreampiovesana commented Nov 11, 2022

github-actions bot commented Mar 12, 2023

HviorForgeFlow commented Mar 13, 2023

github-actions bot commented Jul 23, 2023

etobella commented Aug 27, 2023

github-actions bot commented Jan 7, 2024

HviorForgeFlow left a comment

HviorForgeFlow Jan 8, 2024

HviorForgeFlow Jan 8, 2024


		For testing it is also necessary ``xlrd`` Python module installed::

		$ pip3 install xlrd

		"name": "Extend report xlsx to export directly to pdf",
		"summary": "Extend report xlsx to export directly to pdf",

		@@ -0,0 +1 @@
		This module extend xlsx report to convert in pdf using libreoffice

	This module extend xlsx report to convert in pdf using libreoffice
	This module extend ``report_xlsx`` to convert xlsx to pdf using libreoffice.

		@@ -0,0 +1,10 @@
		Make sure you have ``xlsxwriter`` Python module installed::

	"author": "Openindustry.it," "Odoo Community Association (OCA)",
	"author": "Openindustry.it, Odoo Community Association (OCA)",

[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx #637

[14.0][ADD] report_xlsx_pdf: print directly to PDF from xlsx #637

Conversation

TheMule71 commented Jul 21, 2022

andreampiovesana left a comment

Choose a reason for hiding this comment

andreampiovesana commented Jul 21, 2022

scigghia commented Jul 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheMule71 commented Jul 26, 2022

primes2h commented Jul 27, 2022

TheMule71 commented Jul 27, 2022

sbidoul commented Jul 27, 2022 • edited Loading

etobella commented Jul 28, 2022

TheMule71 commented Jul 28, 2022

primes2h left a comment

Choose a reason for hiding this comment

andreampiovesana commented Aug 23, 2022

etobella left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etobella Aug 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreampiovesana commented Aug 29, 2022

andreampiovesana commented Sep 29, 2022

francesco-ooops commented Sep 29, 2022

andreampiovesana commented Oct 11, 2022 via email

andreampiovesana commented Nov 11, 2022

github-actions bot commented Mar 12, 2023

HviorForgeFlow commented Mar 13, 2023

github-actions bot commented Jul 23, 2023

etobella commented Aug 27, 2023

github-actions bot commented Jan 7, 2024

HviorForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbidoul commented Jul 27, 2022 •

edited

Loading

etobella Aug 27, 2023 •

edited

Loading