-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Avoiding ERROR in log with tests of report_qweb_pdf_watermark #787
Conversation
@bosd @bvanjeelharia @hbrunn @robin5210 Could you please review and approve this tiny change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix pre-commit
@bosd Fixed |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 585ca5d. Thanks a lot for contributing to OCA. ❤️ |
When having 0 pages it will raise and error
https://github.com/BT-rmartin/reporting-engine/blob/16.0-1/report_qweb_pdf_watermark/models/report.py#L56
We are in this way adding a context manager to test that at least one error message is logged on the logger with at least the given level.