Read OIDC metadata from an internal address, and assert the Google redirect URI as emitted - #2541
Merged
Merged
Conversation
An issuer served through a gateway is often unreachable under that name from inside the deployment, which leaves the client registration unable to build and takes the whole context down with it. security.auth.oidc.internalUrl supplies an address that does resolve; discovery and the signing keys are read there while the issuer, and the endpoints a browser is sent to, stay public. Blank keeps the previous behaviour of resolving everything from the issuer.
# Conflicts: # src/main/java/org/ohdsi/webapi/security/authc/OidcAuthConfig.java
Two assertions described behaviour that cannot occur. The redirect URI is carried in a query parameter, where ":" and "/" need no escaping, so it appears verbatim rather than percent-encoded. The other named a server port that disagreed with a portless Host header, which a servlet container cannot produce, and the port then surfaced in the redirect URI. The resolver's output was correct in both cases.
p-hoffmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.