Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Deployment #45

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

AWS Deployment #45

wants to merge 15 commits into from

Conversation

RealOrangeOne
Copy link
Contributor

@RealOrangeOne RealOrangeOne commented Aug 29, 2024 •
edited
Loading

What is the context of this PR?

This PR adds the ability to for the app to be deployed to EKS, based on the infrastructure and helm charts.

There are a few notable changes to the application:

  • Allow authenticating to the DB using IAM credentials
  • Create a dedicated URL for liveness / readiness checks, which hit the DB and cache to confirm they're working correctly.
  • Allow connecting to Elasticache using specific variables (IAM auth is possible, but didn't work after lots of poking, so relegated to a future PR).
  • Allow using a read replica to separate load for read queries

How to review

This change should be entirely additive - it shouldn't break existing development, or the Heroku environment.

@RealOrangeOne RealOrangeOne force-pushed the feature/aws-deployment branch 5 times, most recently from 4f04f82 to 11a9a88 Compare September 3, 2024 08:44
@RealOrangeOne RealOrangeOne marked this pull request as ready for review September 3, 2024 13:55
@RealOrangeOne RealOrangeOne force-pushed the feature/aws-deployment branch 2 times, most recently from 4c1f70d to b564bfe Compare September 11, 2024 15:46
@ONSdigital ONSdigital deleted a comment from RealOrangeOne Sep 12, 2024
@ONSdigital ONSdigital deleted a comment from islas104 Sep 18, 2024
@RealOrangeOne RealOrangeOne marked this pull request as draft September 23, 2024 15:01
@RealOrangeOne
Remove admin link from homepage in external env
4c1766d 
The URL doesn't exist, so there's nothing to reverse
@RealOrangeOne
Use write instance for reads when in a transaction
750615d 
Otherwise data in the transaction may attempt to be read, which causes inconsistency issues.
@RealOrangeOne
Remove connection healthcheck
d1ad904
@RealOrangeOne
Add simple readiness endpoint
ef2d38d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab Awaiting requested review from zerolab

@MebinAbraham MebinAbraham Awaiting requested review from MebinAbraham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RealOrangeOne