Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terraform 1.9.6 install step to eq-terraform-deploy-image #10

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Oct 3, 2024

What is the context of this PR?

This PR is needed for all the eq-terraform-gcp repos we have that require the upgrade from Terraform 1.7.3 to 1.9.6.
eq-terraform-deploy-image is used in multiple tasks and needs to have this upgrade for tfenv so we can use the correct installed version.

How to review

Locally docker build this image and check if it works after, possibly by entering the containerised image shell and checking if 1.9.6 is installed. You can also check this by using your staging eq-terraform-gcp's feature-prepop-terraform-upgrade branch but you would need to point your staging to this docker image pushed to some bucket.

Copy link
Contributor

@liamtoozer liamtoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

Copy link

@Yuyuutsu Yuyuutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.7.3 and v1.9.6 install during the docker build (Tested locally)

@petechd petechd merged commit 0b2e9e7 into main Oct 3, 2024
4 checks passed
@petechd petechd deleted the install-terraform-version-upgrade branch October 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants