Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set outlier weight 1 when target is 0 #98

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

AntonZogk
Copy link
Collaborator

Add another condition for defaults
Add test case in test data
Fix commit hook noqa: E712

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

Add another condition for defaults
Add test case in test data
Fix commit hook noqa: E712
Copy link
Collaborator

@giuliag92 giuliag92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anton, this looks great! Thank you for fixing E712. :)

@AntonZogk AntonZogk merged commit df777e9 into main Oct 9, 2024
3 checks passed
@AntonZogk AntonZogk deleted the 588-edge-case-when-adjusted-value-is-0 branch October 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants