RAS-939 Survey Status Change #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arroyoAle
changed the title
LJBabbage
reviewed
Feb 5, 2024
| complete, CategoryDTO.CategoryName.OFFLINE_RESPONSE_PROCESSED); | ||
|
|
||
| // Then | ||
| assertEquals(CaseGroupStatus.COMPLETE, destinationState); |
There was a problem hiding this comment.
Is this right? I was expecting not started
There was a problem hiding this comment.
You're right I've fixed this
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
SteveScorfield
approved these changes
Feb 12, 2024
| @@ -262,6 +262,10 @@ private StateTransitionManager<CaseState, CaseEvent> caseStateTransitionManager( | |||
| CaseGroupStatus.NOLONGERREQUIRED, | |||
| CategoryDTO.CategoryName.COMPLETED_TO_NOTSTARTED, | |||
| CaseGroupStatus.NOTSTARTED); | |||
| builder.put( | |||
There was a problem hiding this comment.
It's very minor but I'd update the comment to include this transition change as well just to prevent any potential future confusion.
There was a problem hiding this comment.
Comment has been updated
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
LJBabbage
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds a new case group transition from
completetonot startedto allow business users a new status change in rOpsHow to test?
Jira
https://jira.ons.gov.uk/browse/RAS-939