Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1238 Update to docker compose from docker-compose #293

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

arroyoAle
Copy link
Contributor

@arroyoAle arroyoAle commented Aug 12, 2024

What and why?

This PR replaces our use of the docker-compose-maven-plugin as that is still using docker-compose that has been removed
Recreated from #292 with GPG signing

How to test?

Check the build

Jira

RAS-1238

@arroyoAle arroyoAle marked this pull request as ready for review August 12, 2024 07:06
Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOT signing works as expected
docker compose works as expected with new Maven plugin calling shell scripts
Attempted to use paths-ignore which isn't currently being honoured on this PR (but agreed to merge to main and retest with a new PR)

@arroyoAle arroyoAle merged commit 4c8823b into main Aug 14, 2024
1 check passed
@arroyoAle arroyoAle deleted the update-docker-compose-with-gpg-sign branch August 14, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants