Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prod Pipeline Build Type #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibbardsteve
Copy link
Collaborator

Description

The pipeline for deploying from preprod to prod was incorrectly using build type 2 (rollback).
Amended to use build type 3 (deploy).

If you have not checked any of the lists below explain why here.

Note for reviewers: Some files are related to the migrate from preprod to prod - what is our stance on this? Are these to be committed to git?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Technical Enhancements

Checklist:

If any of these are not completed, please explain why in the notes.

Definition of Done

Code and merges

  • Code to be commented on where applicable
  • Documentation updated where required
  • Have considered non-functional requirements such as Security, Performance, Scalability, and Fault Tolerance
  • I have linted the code

Testing

  • All levels of acceptance test are passing (automated, integration, manual, accessibility, etc.)
  • I have run the behave command to check the selenium behaviour tests pass locally
  • Acceptance criteria met

Other Checks

  • I have performed a self-review of my own code
  • I have checked for spelling errors
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes don't break anything unexpected
  • I have checked and updated the security.txt file where required
  • Up to date with the main branch
  • For a change that needs to be deployed in a release I have a commit with the fix:, feat: or BREAKING CHANGE:
    tags and will copy this commit message to the squash
  • For a change that does not affect the deployed code I have added a commit with ci:, docs: or test:
    depending upon which area of the solution was affected

Note when merging, squash commit must begin with one of the following tags:
"BREAKING CHANGE", "feat", "fix", "ci", "docs", "test"

Usage

BREAKING CHANGE: any change that breaks current functionality and may cause compatibility errors to users upgrading
E.G BREAKING CHANGE: refactored method x to take variable y as input (changed from variable z)

feat: A new feature
E.G feat: adding method x to future methods table

fix: A bug fix
E.G fix: amending page for method x to show correct release version

ci: Changes to our CI configuration files and scripts (Concourse)

docs: Documentation only changes

test: Adding missing tests or correcting existing tests

@ons-spp-machine-user
Copy link
Collaborator

DEPLOY_URL=https://d43z7payw6c2v.cloudfront.net/
cloudfront_id=E1J7OLK6OJ7NA8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants