core: tee: initialize dirfile_entry objects

Coverity reports many errors where dirfile_entry{} is used un-initialized. Resolve these errors by setting these objects to zero on declaration. Signed-off-by: Clement Faure <clement.faure@nxp.com> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
OP-TEE · Aug 22, 2023 · f602283 · f602283
1 parent ee8a977
commit f602283
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/core/tee/fs_dirfile.c b/core/tee/fs_dirfile.c
@@ -138,7 +138,7 @@ TEE_Result tee_fs_dirfile_open(bool create, uint8_t *hash,
 		goto out;
 
 	for (n = 0;; n++) {
-		struct dirfile_entry dent;
+		struct dirfile_entry dent = { };
 
 		res = read_dent(dirh, n, &dent);
 		if (res) {
@@ -289,7 +289,7 @@ TEE_Result tee_fs_dirfile_rename(struct tee_fs_dirfile_dirh *dirh,
 				 const void *oid, size_t oidlen)
 {
 	TEE_Result res;
-	struct dirfile_entry dent;
+	struct dirfile_entry dent = { };
 
 	if (oidlen > sizeof(dent.oid))
 		return TEE_ERROR_BAD_PARAMETERS;
@@ -324,7 +324,7 @@ TEE_Result tee_fs_dirfile_remove(struct tee_fs_dirfile_dirh *dirh,
 				 const struct tee_fs_dirfile_fileh *dfh)
 {
 	TEE_Result res;
-	struct dirfile_entry dent;
+	struct dirfile_entry dent = { };
 	uint32_t file_number;
 
 	res = read_dent(dirh, dfh->idx, &dent);
@@ -350,7 +350,7 @@ TEE_Result tee_fs_dirfile_update_hash(struct tee_fs_dirfile_dirh *dirh,
 				      const struct tee_fs_dirfile_fileh *dfh)
 {
 	TEE_Result res;
-	struct dirfile_entry dent;
+	struct dirfile_entry dent = { };
 
 	res = read_dent(dirh, dfh->idx, &dent);
 	if (res)

diff --git a/core/tee/tadb.c b/core/tee/tadb.c
@@ -506,7 +506,7 @@ static TEE_Result find_ent(struct tee_tadb_dir *db, const TEE_UUID *uuid,
 	 * with TEE_ERROR_ITEM_NOT_FOUND.
 	 */
 	for (idx = 0;; idx++) {
-		struct tadb_entry entry;
+		struct tadb_entry entry = { };
 
 		res = read_ent(db, idx, &entry);
 		if (res) {