core: fix fragmented memory retrieve #5966

Jianqiang-Mei · 2023-04-17T07:17:35Z

add spmc_frag_retrieve for fragmented memory retrieve

jenswi-linaro

Please fix the checkpatch complaints.

jenswi-linaro · 2023-04-18T11:25:48Z

core/arch/arm/kernel/thread_spmc.c

+		.a1 = (uint32_t)(cookie),       /* handle high addr */
+		.a2 = (uint32_t)(cookie >> 32), /* handle low addr */
+		.a3 = next_fragment_offset,     /* fragment offset */
+		.a4 = 0x8001,                   /* sender_vm_id */


my_endpoint_id

jenswi-linaro · 2023-04-18T11:27:12Z

core/arch/arm/kernel/thread_spmc.c

+{
+	struct thread_smc_args args = {
+		.a0 = FFA_MEM_FRAG_RX,
+		.a1 = (uint32_t)(cookie),       /* handle high addr */


I'd prefer assigning a1 and a2 with reg_pair_from_64(cookie, &args.a1, &args.a2)

jenswi-linaro · 2023-04-18T11:34:52Z

core/arch/arm/kernel/thread_spmc.c

 		EMSG("Failed to retrieve cookie from rx buffer %#"PRIx64,
 		     cookie);
 		return NULL;
 	}

+	/* Allocate the enough size buffer to copy the fragment descriptor*/
+	retrieve_desc = aligned_alloc(SMALL_PAGE_SIZE, SMALL_PAGE_SIZE * 16);


We should not use a temporary buffer. We should instead consume each fragment as it is received like in handle_mem_frag_tx(). For now, I believe we can assume that each fragment ends with a complete struct ffa_address_range like we do in add_mem_share_helper().

Sorry, I'm not quite clear what you mean for your last sentence. Could you help me revise it？

In add_mem_share_helper() we just assume that the buffer starts at a struct ffa_address_range. I guess it wouldn't hurt to check that flen is a multiple of sizeof(struct ffa_address_range), but the point is that we assume that the SPMC isn't trying to make it harder for us than necessary.

etienne-lms

coding style comments

etienne-lms · 2023-05-05T07:39:16Z

core/arch/arm/kernel/thread_spmc.c

@@ -1383,7 +1383,8 @@ static uint16_t spmc_get_id(void)
 	return args.a2;
 }

-static struct ffa_mem_transaction *spmc_retrieve_req(uint64_t cookie)
+static struct ffa_mem_transaction *spmc_retrieve_req
+(uint64_t cookie, uint32_t *total_length, uint32_t *fragment_length)


static struct ffa_mem_transaction *spmc_retrieve_req(uint64_t cookie, uint32_t *total_length, uint32_t *fragment_length)

etienne-lms · 2023-05-05T09:13:20Z

core/arch/arm/kernel/thread_spmc.c

@@ -1423,7 +1424,8 @@ static struct ffa_mem_transaction *spmc_retrieve_req(uint64_t cookie)
 			     cookie, args.a0);
 		return NULL;
 	}
-
+	*total_length = args.a1;
+	*fragment_length = args.a2;


preserve empty line above

etienne-lms · 2023-05-05T10:11:23Z

core/arch/arm/kernel/thread_spmc.c

+		.a0 = FFA_MEM_FRAG_RX,
+		.a3 = next_fragment_offset,     /* fragment offset */
+		.a4 = my_endpoint_id,           /* sender_vm_id */
+	};


add an empty line below (between local variable definitions and instructions)

etienne-lms · 2023-05-05T10:12:06Z

core/arch/arm/kernel/thread_spmc.c

+	thread_smccc(&args);
+	if (args.a0 != FFA_MEM_FRAG_TX) {
+		if (args.a0 == FFA_ERROR)
+			EMSG("Failed to fetch cookie %#"PRIx64" error code %d",


remove cast below and use PRId64

etienne-lms · 2023-05-05T10:12:23Z

core/arch/arm/kernel/thread_spmc.c

+			     cookie, args.a0);
+		return NULL;
+	}
+	*fragment_length = args.a3;


add an empty line above

etienne-lms · 2023-05-05T10:15:01Z

core/arch/arm/kernel/thread_spmc.c

+		DMSG("Retrieve again, frag offset: %x; total: %x.\n",
+			 next_fragment_offset, length);
+		rx_buffer = spmc_frag_retrieve(handle, next_fragment_offset,
+									   &fragment_length);


indentation issue

etienne-lms · 2023-05-05T10:16:02Z

core/arch/arm/kernel/thread_spmc.c

+		if (rx_buffer) {
+			memcpy((void *)((uint64_t)retrieve_desc +
+				   (uint64_t)next_fragment_offset),
+				   rx_buffer, SMALL_PAGE_SIZE);


indentation:

memcpy((void *)((uint64_t)retrieve_desc + (uint64_t)next_fragment_offset), rx_buffer, SMALL_PAGE_SIZE);

etienne-lms · 2023-05-05T12:02:26Z

core/arch/arm/kernel/thread_spmc.c

@@ -1465,15 +1467,43 @@ static int set_pages(struct ffa_address_range *regions,
 	return 0;
 }

+static struct ffa_mem_transaction *spmc_frag_retrieve
+(uint64_t cookie, uint32_t next_fragment_offset, uint32_t *fragment_length)


maybe prefer

static struct ffa_mem_transaction *spmc_frag_retrieve( uint64_t cookie, uint32_t next_fragment_offset, uint32_t *fragment_length)

github-actions · 2023-06-05T02:01:05Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

etienne-lms · 2023-07-04T08:53:31Z

core/arch/arm/kernel/thread_spmc.c

@@ -1756,6 +1756,8 @@ static uint32_t get_ffa_version(uint32_t my_version)
 }

 static void *spmc_retrieve_req(uint64_t cookie,
+				   uint32_t *total_length,
+				   uint32_t *fragment_length,


fix indentation

etienne-lms · 2023-07-04T08:53:57Z

core/arch/arm/kernel/thread_spmc.c

-		     unsigned int num_regions, unsigned int num_pages,
-		     struct mobj_ffa *mf)
+		     unsigned int num_regions, unsigned int *idx,
+			 struct mobj_ffa *mf)


fix indentation

etienne-lms · 2023-07-04T08:54:18Z

core/arch/arm/kernel/thread_spmc.c

 	return 0;
 }

+static struct ffa_mem_transaction *spmc_frag_retrieve(uint64_t cookie,
+										uint32_t next_fragment_offset,
+										uint32_t *fragment_length)


fix indentation

How to fix？
BTW, where can I see your coding rules？
Thanks.

etienne-lms · 2023-07-04T08:56:42Z

core/arch/arm/kernel/thread_spmc.c

-		      READ_ONCE(descr->address_range_count), num_pages, mf)) {
+	num_regions =
+		MIN(READ_ONCE(descr->address_range_count),
+			(my_rxtx.size - offs) / sizeof(struct ffa_address_range) - 1);


indentation:

MIN(READ_ONCE(descr->address_range_count), (my_rxtx.size - offs) / sizeof(struct ffa_address_range) - 1);

Please be more specific. Thanks

etienne-lms · 2023-07-04T08:57:22Z

core/arch/arm/kernel/thread_spmc.c

+	while (offs < length) {
+		buf = spmc_frag_retrieve(handle, offs, &frag_length);
+		if (buf) {
+			DMSG("Retrieve again, frag_offs:%#"PRIx32"\n", offs);


remove trailing "\n"
offs is of type unsinged int hence s/%#"PRIx32/%u"/

"Retrieve next fragment at offset %#PRIx32"

I meant:

DMSG("Retrieve next fragment at offset %#x", offs);

etienne-lms · 2023-07-04T08:59:44Z

core/arch/arm/kernel/thread_spmc.c

@@ -1882,7 +1915,7 @@ struct mobj_ffa *thread_spmc_populate_mobj_from_rx(uint64_t cookie)
 	 * OP-TEE is only supporting a single mem_region while the
 	 * specification allows for more than one.
 	 */
-	buf = spmc_retrieve_req(cookie, &retrieve_desc);
+	buf = spmc_retrieve_req(cookie, &length, &frag_length, &retrieve_desc);


The function expect uint32_t pointers for those 2 arguments.
Either change the variable types or the function definition.

jenswi-linaro · 2023-07-04T05:53:06Z

core/arch/arm/kernel/thread_spmc.c

@@ -1844,26 +1849,50 @@ void thread_spmc_relinquish(uint64_t cookie)
 }

 static int set_pages(struct ffa_address_range *regions,


I'd prefer the name add_pages_at() now that this function is slightly different.

jenswi-linaro · 2023-07-04T09:16:12Z

core/arch/arm/kernel/thread_spmc.c

+		.a4 = my_endpoint_id,		/* sender_vm_id */
+	};
+
+	reg_pair_from_64(cookie, &args.a2, &args.a1);


I'm sorry, this doesn't work. I've created #6154 to provide suitable helpers to initialize .a2 and .a1 above instead. Until that PR is merged please revert to what you did originally.

jenswi-linaro · 2023-07-04T09:21:14Z

core/arch/arm/kernel/thread_spmc.c

+	while (offs < length) {
+		buf = spmc_frag_retrieve(handle, offs, &frag_length);
+		if (buf) {
+			DMSG("Retrieve again, frag_offs:%#"PRIx32"\n", offs);


"Retrieve next fragment at offset %#PRIx32"

jenswi-linaro · 2023-07-04T09:25:53Z

core/arch/arm/kernel/thread_spmc.c

@@ -1882,7 +1915,7 @@ struct mobj_ffa *thread_spmc_populate_mobj_from_rx(uint64_t cookie)
 	 * OP-TEE is only supporting a single mem_region while the


This comment isn't accurate any longer.

Jianqiang-Mei · 2023-07-04T11:05:41Z

All the indentation problems seem to be related to the github setup. My code has 4 spaces per tab on VSCode, but after push, a tab on github has 8 spaces. Has anyone experienced this problem？

jforissier · 2023-07-04T11:25:24Z

All the indentation problems seem to be related to the github setup. My code has 4 spaces per tab on VSCode, but after push, a tab on github has 8 spaces. Has anyone experienced this problem？

We follow the same coding style as the Linux kernel, so 8 spaces per tab.

Jianqiang-Mei · 2023-07-04T11:29:59Z

All the indentation problems seem to be related to the github setup. My code has 4 spaces per tab on VSCode, but after push, a tab on github has 8 spaces. Has anyone experienced this problem？

We follow the same coding style as the Linux kernel, so 8 spaces per tab.

OK, now I understand the problem and I will solve it soon.

etienne-lms

In commit message: could you state this change relates to FF-A SPMC. somrhting like:

core: arm: spmc: fix fragmented memory retrieve

Adds implementation for memory retrieving for the remaining fragmented
transactions in SPMC.

etienne-lms · 2023-07-04T12:05:56Z

core/arch/arm/kernel/thread_spmc.c

-static int set_pages(struct ffa_address_range *regions,
-		     unsigned int num_regions, unsigned int num_pages,
+static int add_pages_at(struct ffa_address_range *regions,
+		     unsigned int num_regions, unsigned int *idx,


indenation issue here also (sorry, i guess i missed it)

etienne-lms · 2023-07-04T12:08:24Z

core/arch/arm/kernel/thread_spmc.c

 	return 0;
 }

+static struct ffa_mem_transaction *spmc_frag_retrieve(uint64_t cookie,
+					uint32_t next_fragment_offset,
+					uint32_t *fragment_length)


Indentation.
Suggestion: shorten next_fragment_offset to next_frq_offset:

static struct ffa_mem_transaction *spmc_frag_retrieve(uint64_t cookie, uint32_t next_frag_offset, uint32_t *fragment_length) { ... }

etienne-lms · 2023-07-04T12:11:28Z

core/arch/arm/kernel/thread_spmc.c

+		buf = spmc_frag_retrieve(handle, offs, &frag_length);
+		if (buf) {
+			DMSG("Retrieve next fragment at offset %#"PRIx32,
+			     offs);


DMSG("Retrieve next fragment at offset %#x", offs);

etienne-lms · 2023-07-04T12:13:17Z

core/arch/arm/kernel/thread_spmc.c

+	while (offs < length) {
+		buf = spmc_frag_retrieve(handle, offs, &frag_length);
+		if (buf) {
+			DMSG("Retrieve again, frag_offs:%#"PRIx32"\n", offs);


I meant:

DMSG("Retrieve next fragment at offset %#x", offs);

Jianqiang-Mei · 2023-07-04T12:30:27Z

In commit message: could you state this change relates to FF-A SPMC. somrhting like:
core: arm: spmc: fix fragmented memory retrieve

Adds implementation for memory retrieving for the remaining fragmented
transactions in SPMC.

Done

jenswi-linaro · 2023-07-04T12:45:33Z

core/arch/arm/kernel/thread_spmc.c

@@ -1873,16 +1902,17 @@ struct mobj_ffa *thread_spmc_populate_mobj_from_rx(uint64_t cookie)
 	struct mobj_ffa *mf = NULL;
 	unsigned int num_pages = 0;
 	unsigned int offs = 0;
+	unsigned int num_regions = 0;


range_count would match the FF-A terminology better.

jenswi-linaro · 2023-07-04T12:57:02Z

core/arch/arm/kernel/thread_spmc.c

@@ -1898,8 +1928,31 @@ struct mobj_ffa *thread_spmc_populate_mobj_from_rx(uint64_t cookie)
 	if (!mf)
 		goto out;

-	if (set_pages(descr->address_range_array,
-		      READ_ONCE(descr->address_range_count), num_pages, mf)) {
+	num_regions = MIN(READ_ONCE(descr->address_range_count),


We should check that frag_len is less than length and the size of the rx buffer.
I'm not sure we even need to look at descr->address_range_count.

offs += offsetof(struct ffa_mem_region, address_range_array); range_count = (frag_len - offs) / sizeof(struct ffa_address_range);

We should check that frag_len is less than length and the size of the rx buffer.

Done

I'm not sure we even need to look at descr->address_range_count.

offs += offsetof(struct ffa_mem_region, address_range_array); range_count = (frag_len - offs) / sizeof(struct ffa_address_range);

If I understand correctly, descr->address_range_count represents the number of constituent memory region descriptors. And there is a formulation:
length - offs = sizeof (ffa_address_range) * descr->address_range_count
if descr->address_range_count does not satisfy this relation, it will eventually fail to pass the check as follows:

if (idx != num_pages) { mobj_ffa_spmc_delete(mf); goto out; }

Sure, we could check descr->address_range_count, but depending on what we're doing with the value it might not be that useful.

Do I need to do anything else? In addition, will the fix be merged into the optee 3.22 version？

Please add Jens' review tag (below). I think it makes sense to take this for 3.22.0.

jenswi-linaro · 2023-07-04T12:58:23Z

core/arch/arm/kernel/thread_spmc.c

+		buf = spmc_frag_retrieve(handle, offs, &frag_length);
+		if (buf) {
+			DMSG("Retrieve next fragment at offset %#x", offs);
+			num_regions = frag_length /


Need to check that frag_length isn't larger than the size of the rx buffer.

jenswi-linaro

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

Add implementation for memory retrieving for the remaining fragmented transactions. Link: OP-TEE#5966 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Jianqiang,Mei <meijianqiang.mjq@alibaba-inc.com>

jenswi-linaro · 2023-07-06T11:27:15Z

Looks good.

etienne-lms

Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

Add implementation for memory retrieving for the remaining fragmented transactions. Link: OP-TEE#5966 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Jianqiang,Mei <meijianqiang.mjq@alibaba-inc.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

etienne-lms · 2023-07-07T12:13:44Z

@jforissier, @jenswi-linaro, could you enable CI test for this P-R?

jforissier · 2023-07-07T13:08:32Z

@jforissier, @jenswi-linaro, could you enable CI test for this P-R?

Done.

jenswi-linaro · 2023-07-11T06:44:24Z

This should be good to merge now.

Master-Chi · 2023-07-11T08:08:35Z

core/arch/arm/kernel/thread_spmc.c

 	return 0;
 }

+static struct ffa_mem_transaction *spmc_frag_retrieve(uint64_t cookie,


struct ffa_mem_transaction or struct ffa_address_range ?

Yes, I believe that's correct.

Sorry for missing check in detail. ffa_mem_transaction doesn't like a good fit, or modify it to the （void *） type to be consistent with the function spmc_retrieve_req return type, what do you think?

That's fine too.

Add implementation for memory retrieving for the remaining fragmented transactions. Link: OP-TEE#5966 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Jianqiang,Mei <meijianqiang.mjq@alibaba-inc.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

jenswi-linaro · 2023-07-11T09:57:25Z

Looks good.

Master-Chi · 2023-07-12T09:16:28Z

core/arch/arm/kernel/thread_spmc.c

+		.a1 = (uint32_t)(cookie),        /* handle high addr */
+		.a2 = (uint32_t)(cookie >> 32),  /* handle low addr */
+		.a3 = next_frag_offset,          /* offset */
+		.a4 = my_endpoint_id,            /* sender_vm_id */


in FF-A v1.1
w4 – Bit[31:16]: Endpoint ID
– Bit[15:0]: Reserved (MBZ).

maybe it should be sender_id(linux or hyp) << 16 ?

A complete description of the parameter：
• ID of the Owner or Borrower endpoint.
– Bit[31:16]: Endpoint ID.
– Bit[15:0]: Reserved (MBZ).
• Reserved (MBZ) at any virtual FF-A instance.
In this scenario, the optee should be the Borrower, so modify the code as follows:
.a4 = my_endpoint_id << 16, /* sender_vm_id */
right?

or Reserved (MBZ) at any virtual FF-A instance，and
.a4 = 0, /* sender_vm_id */
According to the implementation of Hafnium, this should be right. I'm not really sure.

i think 0 is fine, reference:
https://github.com/ARM-software/arm-trusted-firmware/blob/e318411f02f8a9526c97a23d0cdada2f128446e3/services/std_svc/spm/el3_spmc/spmc_shared_mem.c#L1682

i am confused too about the description "Owner or Borrower", i think they are different roles.
i think sender_id used in optee maybe is not optee partiton id, reference:

optee_os/core/arch/arm/kernel/thread_spmc.c

Line 1776 in a871924

trans_descr->sender_id = thread_get_tsd()->rpc_target_info;

Master-Chi · 2023-07-12T09:44:49Z

core/arch/arm/kernel/thread_spmc.c

+	uint32_t length = 0;
+	uint32_t frag_length = 0;
+	uint64_t handle = 0;
+	unsigned int idx = 0;
 	void *buf = NULL;
 	struct thread_smc_args ffa_rx_release_args = {
 		.a0 = FFA_RX_RELEASE


Maybe FFA_RX_RELEASE should be submitted after each FFA_MEM_FRAG_RX or FFA_MEM_RETRIEVE_REQ_32, or rx buffer is full in spmc perspective

rx buffer is full in spmc perspective, The specification does not seem to say anything about this.
What happens if I release rx_buffer after the complete retrieve?

@jenswi-linaro Do you have any good suggestions？

yes, the specification says nothing about it.
but i think the implementation of trusted firmware requires that.
ref:
https://github.com/ARM-software/arm-trusted-firmware/blob/e318411f02f8a9526c97a23d0cdada2f128446e3/services/std_svc/spm/el3_spmc/spmc_shared_mem.c#L1704

ok, it does need to be released several times, and I will modify it as soon as possible.

Add implementation for memory retrieving for the remaining fragmented transactions. Link: OP-TEE#5966 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Jianqiang,Mei <meijianqiang.mjq@alibaba-inc.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

jenswi-linaro · 2023-07-12T12:54:01Z

core/arch/arm/kernel/thread_spmc.c

+		.a1 = (uint32_t)(cookie),        /* handle high addr */
+		.a2 = (uint32_t)(cookie >> 32),  /* handle low addr */
+		.a3 = next_frag_offset,          /* offset */
+		.a4 = 0,			 /* MBZ */


This assignment can be skipped. But a comment would be nice, saying something like:

/* w4 MBZ since we're a virtual instance */

If a4 assignment skipped, how to pass check in el3 spmc, like
https://github.com/ARM-software/arm-trusted-firmware/blob/e318411f02f8a9526c97a23d0cdada2f128446e3/services/std_svc/spm/el3_spmc/spmc_shared_mem.c#L1682
and check in Hafnium

/* Sender ID MBZ at virtual instance. */ if (vm_id_is_current_world(to->id)) { if (sender_vm_id != 0) { dlog_verbose("%s: Invalid sender.\n", __func__); return ffa_error(FFA_INVALID_PARAMETERS); } }

do you mean
.a4 = 0, /* w4 MBZ since we're a virtual instance */

No, just the comment.

jenswi-linaro · 2023-07-13T10:35:06Z

By the way, how do you test this patch?

Jianqiang-Mei · 2023-07-13T11:21:36Z

By the way, how do you test this patch?

In the case of hello_world, you can add a const global variable to hello_world_ta.c, like:
const char test_char[10 * 1024 * 1024];
After build, TA's size will be increased by 10MB.
In this case, linux kernel will most likely allocate much discontinuous fragment memory,
and an rx_buffer will not be enough to include the address information of these shared memory,
and FFA_MEM_FRAG_RX is then used.

Jianqiang-Mei · 2023-07-14T06:31:57Z

By the way, how do you test this patch?

In the case of hello_world, you can add a const global variable to hello_world_ta.c, like: const char test_char[10 * 1024 * 1024]; After build, TA's size will be increased by 10MB. In this case, linux kernel will most likely allocate much discontinuous fragment memory, and an rx_buffer will not be enough to include the address information of these shared memory, and FFA_MEM_FRAG_RX is then used.

@jenswi-linaro If a4 assignment skipped, can you pass this test?
Is there anything else need I to do for this point, or leave it to you?

jenswi-linaro · 2023-07-14T06:54:17Z

I can't get that to work, I don't even reach spmc_frag_retrieve(). I'm testing this with:
OP-TEE/manifest#241
OP-TEE/build#663
make SPMC_AT_EL=2

Edit: On QEMU.

Jianqiang-Mei · 2023-07-18T06:28:26Z

I can't get that to work, I don't even reach spmc_frag_retrieve(). I'm testing this with: OP-TEE/manifest#241 OP-TEE/build#663 make SPMC_AT_EL=2

Edit: On QEMU.

It seems to be related to changes to thread_smccc(&ffa_rx_release_args).
I'll push a new version.

Add implementation for memory retrieving for the remaining fragmented transactions. Link: OP-TEE#5966 Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Jianqiang,Mei <meijianqiang.mjq@alibaba-inc.com> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>

Jianqiang-Mei · 2023-07-30T09:51:48Z

@jenswi-linaro
Sorry for the lack of communication over the last two weeks.
I tested this fix myself and it works fine, please let me know if there are any other problems.

jenswi-linaro · 2023-08-01T14:31:53Z

I'm not able to reproduce it. Can you see if you can on QEMU? I'm using this setup:

repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml
repo sync
cd build
make toolchains
# Update optee_os to use your patch +
# increase MAX_XLAT_TABLES to avoid a panic
# Update optee_examples, hello world TA with const char test_char[10 * 1024 * 1024]
make SPMC_AT_EL=2 CFG_NUM_THREADS=6 all
make SPMC_AT_EL=2 run-only

github-actions · 2023-09-01T01:30:31Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 4c534f3 to 34e08df Compare April 17, 2023 08:54

jenswi-linaro reviewed Apr 18, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 34e08df to ad985fc Compare May 5, 2023 03:05

etienne-lms reviewed May 5, 2023

View reviewed changes

github-actions bot added the Stale label Jun 5, 2023

github-actions bot closed this Jun 11, 2023

jenswi-linaro reopened this Jun 28, 2023

Jianqiang-Mei force-pushed the dev_frag_retrieve branch 3 times, most recently from c6a7f33 to 2d224a0 Compare July 4, 2023 07:23

etienne-lms reviewed Jul 4, 2023

View reviewed changes

jenswi-linaro reviewed Jul 4, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 2d224a0 to 8b7a01d Compare July 4, 2023 11:00

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 8b7a01d to 66e7ca9 Compare July 4, 2023 11:58

etienne-lms reviewed Jul 4, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch 4 times, most recently from f83ca40 to 5f1efd0 Compare July 4, 2023 12:43

jenswi-linaro reviewed Jul 4, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 5f1efd0 to 9b9bfb5 Compare July 4, 2023 13:51

github-actions bot removed the Stale label Jul 5, 2023

jenswi-linaro reviewed Jul 5, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 9b9bfb5 to fe1b464 Compare July 5, 2023 08:18

etienne-lms approved these changes Jul 6, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 572661a to 1860299 Compare July 6, 2023 12:56

Master-Chi reviewed Jul 11, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 1860299 to aacc759 Compare July 11, 2023 08:36

Master-Chi reviewed Jul 12, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from aacc759 to 7174313 Compare July 12, 2023 12:45

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 7174313 to 876e32f Compare July 12, 2023 12:48

jenswi-linaro reviewed Jul 12, 2023

View reviewed changes

Jianqiang-Mei force-pushed the dev_frag_retrieve branch from 876e32f to 9b2743d Compare July 18, 2023 06:56

github-actions bot added the Stale label Sep 1, 2023

github-actions bot closed this Sep 7, 2023

		@@ -1844,26 +1849,50 @@ void thread_spmc_relinquish(uint64_t cookie)
		}

		static int set_pages(struct ffa_address_range *regions,

		@@ -1882,7 +1915,7 @@ struct mobj_ffa *thread_spmc_populate_mobj_from_rx(uint64_t cookie)
		* OP-TEE is only supporting a single mem_region while the

core: fix fragmented memory retrieve #5966

core: fix fragmented memory retrieve #5966

Conversation

Jianqiang-Mei commented Apr 17, 2023

jenswi-linaro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jianqiang-Mei May 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etienne-lms left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jianqiang-Mei commented Jul 4, 2023 • edited Loading

jforissier commented Jul 4, 2023

Jianqiang-Mei commented Jul 4, 2023 • edited Loading

etienne-lms left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jianqiang-Mei commented Jul 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jianqiang-Mei Jul 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jenswi-linaro left a comment

Jianqiang-Mei May 5, 2023 •

edited

Loading

Jianqiang-Mei commented Jul 4, 2023 •

edited

Loading

Jianqiang-Mei commented Jul 4, 2023 •

edited

Loading

Jianqiang-Mei Jul 4, 2023 •

edited

Loading