Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: arm: plat-versal: Add maybe_unused attribute to constant strings #6232

Merged

Conversation

sriramsriram-msft
Copy link
Contributor

@sriramsriram-msft sriramsriram-msft commented Aug 9, 2023

If log level is set to print only EMSGs, constant strings can be unused. Add maybe_unused attribute to prevent compilation errors.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

If log level is set to print only EMSGs, constant strings can be unused.
Add maybe_unused attribute to prevent compilation errors.

Signed-off-by: Sriram Sriram <sriramsriram@microsoft.com>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
@sriramsriram-msft
Copy link
Contributor Author

This PR can be merged.

@jforissier jforissier merged commit e708156 into OP-TEE:master Aug 22, 2023
6 checks passed
@sriramsriram-msft sriramsriram-msft deleted the user/srirams/fix-versal-bug branch August 22, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants