core: fix data abort during ftrace #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenswi-linaro
force-pushed
the
fix_ftrace
branch
from
28d52c4
to
df68c0b
Compare
|
Force push to please checkpatch. |
etienne-lms
reviewed
Oct 13, 2023
|
|
With commit c10e3fa ("core: fix race in handling TA panic") the resources of a panicked TAs are released as early as possible, including the user space mapped ftrace buffer. However, the pointer to the ftrace buffer is stored in the ts_session for quick and easy access. The ftrace buffer is always retrieved with get_fbuf() that already have a few other checks to see if the buffer is currently available. So add a check to see that the TA hasn't panicked also. Fixes: c10e3fa ("core: fix race in handling TA panic") Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a)
jenswi-linaro
force-pushed
the
fix_ftrace
branch
from
df68c0b
to
4331523
Compare
|
Tags applied. Did a |
|
Does this change disallows ftrace dump for user TAs which have panicked? |
No. I could obtain a dump for e.g., |
jforissier
added a commit
to jforissier/optee_release_tests
that referenced
this pull request
Oct 13, 2023
Enable test 11 again since the issue waw fixed in [1]. Link: OP-TEE/optee_os#6378 [1]. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit c10e3fa ("core: fix race in handling TA panic") the resources of a panicked TAs is released as early as possible, including the user space mapped ftrace buffer. However, the pointer to the ftrace buffer is stored in the ts_session for quick and easy access. The ftrace buffer is always retrieved with get_fbuf() that already have a few other checks to see if the buffer is currently available. So add a check to see that the TA hasn't panicked also.
Fixes: c10e3fa ("core: fix race in handling TA panic")