Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: arm: rpc_alloc: remove size limit for kernel payload #6409

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

jenswi-linaro
Copy link
Contributor

Removes the size limit of 1 page imposed in
thread_rpc_alloc_kernel_payload(). The purpose of this limit was to error out early since the kernel doesn't supply a list of physical pages and the source of the error is not obvious at first glance. This is now about to change so remove the limit since the kernel now may supply the needed list of physical pages.

Link to corresponding kernel patch https://lore.kernel.org/lkml/20231026171650.515275-1-jens.wiklander@linaro.org/

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

@jenswi-linaro
Copy link
Contributor Author

Tag applied. We may want to wait a little with merging this until we see how the kernel patch is received.

@jforissier
Copy link
Contributor

Tag applied. We may want to wait a little with merging this until we see how the kernel patch is received.

Sure.

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>

Removes the size limit of 1 page imposed in
thread_rpc_alloc_kernel_payload(). The purpose of this limit was to
error out early since the kernel doesn't supply a list of physical pages
and the source of the error is not obvious at first glance. This is
now about to change so remove the limit since the kernel now may
supply the needed list of physical pages.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
@jenswi-linaro
Copy link
Contributor Author

jenswi-linaro commented Dec 11, 2023

Tag applied and rebased on master.

@jenswi-linaro
Copy link
Contributor Author

The corresponding kernel patches have been reviewed. I believe this is ready to be merged now.

@jforissier jforissier merged commit 6c884c9 into OP-TEE:master Dec 11, 2023
8 checks passed
@jenswi-linaro jenswi-linaro deleted the kern_priv_shm branch December 11, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants