Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat-k3: set TRNG as enabled unconditionally #7052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glneo
Copy link
Contributor

@glneo glneo commented Sep 23, 2024

All K3 devices already have this enabled, remove the check and set this unconditionally.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message can be misleading IMHO. The RRNG is now default disabled for all k3 based platforms, not set unconditionally as external build config directives can still override the default config and enable PRNG.
That said, Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> (I may be too picky :)

Copy link

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Oct 25, 2024
All K3 devices already have PRNG disabled, remove the check and
set this unconditionally.

Signed-off-by: Andrew Davis <afd@ti.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
@glneo
Copy link
Contributor Author

glneo commented Oct 31, 2024

Ping, seems this got closed due to inactivity..

@jforissier jforissier reopened this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants