-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtest: regression: add case 1040 #693
Conversation
host/xtest/regression_1000.c
Outdated
TEEC_Session session = { }; | ||
size_t n = 0; | ||
|
||
while (n < 100) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to tune this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use the test level global level
to tune that value (I understand one may want to increase this value).
This test case will fail without OP-TEE/optee_os#6281 |
} | ||
n++; | ||
} | ||
return NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicitly set a->res = TEE_SUCCESS
to clarifies the test at line 3331?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
host/xtest/regression_1000.c
Outdated
for (n = 0; n < nt; n++) { | ||
if (!ADBG_EXPECT(c, 0, pthread_create(&arg[n].thr, NULL, | ||
test_1040_thread, | ||
arg + n))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation issue
Update |
host/xtest/regression_1000.c
Outdated
TEEC_Session session = { }; | ||
size_t n = 0; | ||
|
||
while (n < 100) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use the test level global level
to tune that value (I understand one may want to increase this value).
host/xtest/regression_1000.c
Outdated
ADBG_EXPECT_TEEC_SUCCESS(c, arg[n].res); | ||
} | ||
Do_ADBG_EndSubCase(c, "Concurent invoke with panic in TA"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the empty line
Could you retrigger CI tests? OP-TEE/optee_os#6281 has been merged. |
Update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
Adds regression case 1040 to test panic in concurrent open/invoke/close session. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
bb276ce
to
b8f5f92
Compare
Squashed, rebased and tag applied. |
Adds regression case 1040 to test panic in concurrent open/invoke/close session.