F/drupal11 - #346
Open
stankut wants to merge 23 commits into
Open
Conversation
jekuaitk
requested changes
Aug 26, 2026
jekuaitk
left a comment
jekuaitk
left a comment
Contributor
There was a problem hiding this comment.
A couple questions otherwise good!
Comment on lines
+109
to
+111
| "drupal/webform_node_element", | ||
| "drupal/events_logging", | ||
| "drupal/switch_page_theme" |
Contributor
There was a problem hiding this comment.
The continuous need for drupal lenient comes with annoyances, cf. #244. But i suppose that should be considered and/or handled separately!
Contributor
There was a problem hiding this comment.
Looks to me like this is missing the addition of $typedConfigManager that was added to other setting forms extending ConfigFormBase.
| ]; | ||
|
|
||
| $this->messenger()->addMessage(\Drupal::service('renderer')->renderPlain($build), $file_type); | ||
| $this->messenger()->addMessage(\Drupal::service('renderer')->renderPlain($build)); |
Contributor
There was a problem hiding this comment.
This was probably meant to be $type, c.f. the method signature
protected function debug($message, $state, $file_path, $type = 'warning') {....
However, since no one uses it (#321) i'm okay with this solution.
| "drupal/advancedqueue": "^1.0", | ||
| "drupal/cache_control_override": "^1.1 || ^2.0", | ||
| "drupal/coc_forms_auto_export": "^3.0@alpha", | ||
| "drupal/config_entity_revisions": "2.0.x-dev", |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drupal 11 compatibility