Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'source' instead of 'configfile' in generated grub.cfg #2337

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Use 'source' instead of 'configfile' in generated grub.cfg #2337

merged 1 commit into from
Jul 28, 2023

Conversation

slowpeek
Copy link
Contributor

Fixes #2320

@slowpeek slowpeek mentioned this pull request Jul 27, 2023
Closed
@slowpeek
Copy link
Contributor Author

I see the problems with the tests. Fixing it ..

@slowpeek
Copy link
Contributor Author

The checks should pass this time but I rebased one extra commit, will fix it

@slowpeek
Copy link
Contributor Author

Looks good now

@schaefi
Copy link
Collaborator

schaefi commented Jul 27, 2023

yep looks good, I'd like to have @davidcassany and @Conan-Kudo to take a look at this one too. Thanks

Conan-Kudo
Conan-Kudo approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@Conan-Kudo Conan-Kudo merged commit 5598493 into OSInside:master Jul 28, 2023
12 checks passed
@slowpeek slowpeek deleted the use-source branch July 28, 2023 19:38
@marcan
Copy link

marcan commented Aug 29, 2023

FYI, this creates a timebomb with Fedora/RH installs that explodes on the next GRUB update: https://bugzilla.redhat.com/show_bug.cgi?id=2235692

I don't consider this a Kiwi bug, but you should be aware since I expect more than just Asahi Linux users are affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grub menu problem with live isos in EFI mode
4 participants
@slowpeek @schaefi @marcan @Conan-Kudo