-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bsc#1209302: add some hints about KIWI extensions and dependencies for SLES #2348
Conversation
SUSE Linux Enterprise Server (SLES) has KIWI as a package. However, some KIWI extensions and their dependencies can be unavailable. This commit introduces a new section which deals with this aspect.
I believe that "However, if your rely on some extensions for..." is not valid English. due to the way "your" is used in-place. I assume a more equitable version is of a form similar to: "However, if your attempted installation shows reliance on some extensions for...". I'm sorry I can't find a way to say it as a reviewer. |
Yes, thanks @mairda. That was a typo. Should be "you" instead of "your":
I see your point. We could maybe extend the above paragraph and weave into "installation". Taking the "extension" -> "plugin" into account, I get this:
Better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort on the docs. This makes complete sense to me and I think we could make it more clear by pointing out an example. See my review comments. Thanks much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
If anything else needs to be corrected, let me know. |
Ultra pedantic and not things I demand, but...
|
SUSE Linux Enterprise Server (SLES) has KIWI as a package. However, some KIWI extensions and their dependencies can be unavailable.
This commit introduces a new section which deals with this aspect.
Fixes bsc#1209302.
Changes proposed in this pull request:
Keep in mind, this was deliberately kept general to fit all extensions.