Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TOML markup #2375

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Support TOML markup #2375

merged 1 commit into from
Nov 8, 2023

Conversation

schaefi
Copy link
Collaborator

@schaefi schaefi commented Sep 13, 2023

Allow to use TOML markup for the kiwi image description This Fixes #2372

Allow to use TOML markup for the kiwi image description
This Fixes #2372
@schaefi schaefi self-assigned this Sep 13, 2023
@schaefi
Copy link
Collaborator Author

schaefi commented Sep 13, 2023

To convert your image description to TOML call

kiwi-ng image info --description path/to/description --print-toml

Take the output and place it into a file that has to end with .kiwi Description files with this extension goes through anymarkup on reading and will be parsed in their markup

@schaefi
Copy link
Collaborator Author

schaefi commented Sep 13, 2023

I did not add support for TOML so far because it adds a new python module requirement as you know.
I don't think this change here is backward compatible, but supporting more markups is easy :)

@schaefi
Copy link
Collaborator Author

schaefi commented Nov 8, 2023

@Conan-Kudo I haven't heard back from the anymarkup people and guess they are not interested. I would continue adding the toml support but implement it as a plugin such that we don't create a hard requirement to the toml module. Thoughts ?

@Conan-Kudo
Copy link
Member

I'm concerned that anymarkup might be abandoned. If that's the case, we're going to have to take ownership of that module.

@schaefi
Copy link
Collaborator Author

schaefi commented Nov 8, 2023

I'm concerned that anymarkup might be abandoned. If that's the case, we're going to have to take ownership of that module.

It's a different question. From my perspective it's not an orphan module but there is not much development happening anymore and it just does it's job in a good way. If need be we can certainly take ownership. From today's perspective and dev power in the kiwi team I would say it will not get more attention that it gets now ;)

Brings me back to the question if we should support the TOML markup in plugin style to prevent kiwi from another requirement or if we should not add TOML markup support at all ? I don't have any pressing requests for TOML but as we have YAML and coding that as a plugin is easy why not do it ?

@Conan-Kudo
Copy link
Member

Let's ship it as-is. Even the toml module's dead state isn't that big of a deal right now.

@Conan-Kudo Conan-Kudo merged commit 7c259e6 into master Nov 8, 2023
12 checks passed
@Conan-Kudo Conan-Kudo deleted the support_toml_markup branch November 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding TOML as a supported description format
2 participants