Move VolumeManager to context manager #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to run this through the Staging pipeline |
schaefi
force-pushed
the
volume_manager_to_context_manager
branch
from
df6b618
to
5bc4be3
Compare
|
Submitting a Staging build... |
dcermak
reviewed
Feb 20, 2024
schaefi
force-pushed
the
volume_manager_to_context_manager
branch
3 times, most recently
from
0d0cf11
to
e20f216
Compare
dcermak
approved these changes
Feb 21, 2024
Change the VolumeManager Factory to be a context manager.
All code using VolumeManager was updated to the following
with statement:
with VolumeManager(...).new as volume_manager:
volume_manager.some_member()
This is related to Issue #2412
schaefi
force-pushed
the
volume_manager_to_context_manager
branch
from
1de9cba
to
a39a19b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the VolumeManager Factory to be a context manager. All code using VolumeManager was
updated to the following with statement:
This is related to Issue #2412