Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ramdisk size setup #2634

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fixed ramdisk size setup #2634

merged 1 commit into from
Sep 6, 2024

Conversation

schaefi
Copy link
Collaborator

@schaefi schaefi commented Sep 3, 2024

For setting up the brd rd_size option kiwi creates 99-brd.conf used at load time of the kernel brd driver. The location for the conf file is set to /etc/modprobe.d/ However, in newer versions the location has changed to /usr/lib/modprobe.d/ and /etc/modprobe.d no longer exists. This commit allows to handle both systems

@schaefi schaefi self-assigned this Sep 3, 2024
Copy link
Member

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should never create files in /usr/lib/modprobe.d. If the directory in /etc doesn't exist and we need to put a file there, we need to create the directory.

@davidcassany
Copy link
Collaborator

I agree with @Conan-Kudo , creating a file in /usr/lib/modprobe.d feels wrong, moreover after some time we (or someone else) are likely to be puzzled by this file not provided by any package and mysteriously added into a sensitive location.
If the path /etc/modprobe.d is is still honored I'd say that's the way to go and relay on a mkdir -p /etc/modprobe.d or similar approach to ensure the path exists.

@schaefi
Copy link
Collaborator Author

schaefi commented Sep 5, 2024

ok, thanks I will do so. Let's hope the /etc location is still honored. Thanks

@schaefi
Copy link
Collaborator Author

schaefi commented Sep 6, 2024

@Conan-Kudo @davidcassany ok, I updated the PR, can you take a look again ? Thanks

For setting up the brd rd_size option kiwi creates
99-brd.conf used at load time of the kernel brd driver.
The location for the conf file is set to /etc/modprobe.d/
However, in newer versions the location has changed to
/usr/lib/modprobe.d/ and /etc/modprobe.d is no longer
expected to exist. This commit makes sure /etc/modprobe.d
is created if not present.
@schaefi schaefi merged commit 1e248da into main Sep 6, 2024
12 checks passed
@schaefi schaefi deleted the fix_ramdisk_size_setup branch September 6, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants