Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary waits from e2e tests #1106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nashluffy
Copy link
Contributor

Description

For all the tests I've changed, there are existing assertions that the cluster/sentinel/redis is ready, so the sleeps are unnecessary. From the looks of it, they predate the ready assertions.

Partial fix for #1104

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

It's very possible there's additional context I'm missing on why these sleeps are still in the codebase.

Signed-off-by: mluffman <mluffman@thoughtmachine.net>
Signed-off-by: mluffman <mluffman@thoughtmachine.net>
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.67%. Comparing base (d121d86) to head (2278d09).
Report is 120 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1106       +/-   ##
===========================================
+ Coverage   35.20%   45.67%   +10.47%     
===========================================
  Files          19       20        +1     
  Lines        3213     2704      -509     
===========================================
+ Hits         1131     1235      +104     
+ Misses       2015     1387      -628     
- Partials       67       82       +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant