-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Add] Secrets generation by the Operator #391
Open
shubham-cmyk
wants to merge
18
commits into
OT-CONTAINER-KIT:master
Choose a base branch
from
shubham-cmyk:secretsGen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-cmyk
changed the title
Secrets gen by Operator
[Feature][Add] Secrets generation by the Operator
Nov 30, 2022
iamabhishek-dubey
requested changes
Dec 5, 2022
iamabhishek-dubey
requested changes
Jan 7, 2023
iamabhishek-dubey
pushed a commit
that referenced
this pull request
Jan 16, 2023
Any reason not to leverage https://redis.io/commands/acl-genpass/ ? |
This could be used that's why this PR was on hold for so long |
@darkrift I would like you to invite to slack channel : Join our #redis-operator Slack Channel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269
Secrets now can be generate by the operator.
Package added : https://github.com/google/uuid // for the Password generation.
Expected Working :
User can either create the secret itself or offload the generation to the operator.
Operator Create the Secret using the given name and namespace;
If namespace is empty the namespace of the redis setup is taken by the operator.
if no key is passed the default key is "key"