Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian (fa) edition for API Security 2023 #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

This-is-Neo
Copy link
Contributor

Add Persian (fa) edition for API Security 2023

@This-is-Neo
Copy link
Contributor Author

#134

Copy link
Collaborator

@PauloASilva PauloASilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @This-is-Neo,
The PR needs some changes before becoming ready for merge.
Please kindly review my comments.

Remember that you can render the site locally using docker. To add the Persian translation to the languages selector you should do the following change:

diff --git a/editions/2023/mkdocs.yml b/editions/2023/mkdocs.yml
index e4f73e3..505c4d2 100644
--- a/editions/2023/mkdocs.yml
+++ b/editions/2023/mkdocs.yml
@@ -9,3 +9,5 @@ extra:
       lang: en
     - name: Français
       lang: fr
+    - name: Persian
+      lang: fa

Also note that we are no longer providing the ODT/PDF versions of the document due to the additional effort required to keep them up to date. In the future we may consider providing distributable formats as long as they can be compiled from the source.

Cheers,
Paulo A. Silva

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't supposed to be here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several broken links here e.g. 0xa2-broken-user-autentication.md does not exist: the file name is 0xa2-broken-autentication.md.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several Markdown rendering issues throughout the sections:

  • Tables image
  • References image

@@ -0,0 +1,89 @@
<div dir="rtl" align='right'>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required since MkDocs already takes care of it:

image

Code blocks are properly handled:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants