Skip to content

Updating connection name for oracle - #1705

Merged
benPearce1 merged 1 commit into
masterfrom
fix-oracle-add-role
Aug 31, 2026
Merged

Updating connection name for oracle#1705
benPearce1 merged 1 commit into
masterfrom
fix-oracle-add-role

Conversation

@twerthi

@twerthi twerthi commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Background

This template uses the SimplySql cmdlet. SimplySql added a connection name property which uses the value of default. When this template would fail, it would hit the finally statement and try to close the default conneciton and fail since it was never opened in the first place which would mask the original error.

Results

This updates the template to use the named connections and tests the connection to see if it is open before closing.

Before

When the template would fail before establishing a connection, the finally would fail attempting to close a connection that wasn't open and mask the original error.

After

Adds the connection name property and a test to see if the connection is open before trying to close it. This no longer masks the original error.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • $Meta must have ExportedAt and OctopusVersion updated
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

@github-actions

Copy link
Copy Markdown

Review this PR in Hyponome for a side-by-side diff of the step-template JSON and any embedded scripts.

@benPearce1
benPearce1 merged commit 0195956 into master Aug 31, 2026
4 checks passed
@benPearce1
benPearce1 deleted the fix-oracle-add-role branch August 31, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants