Updating grate code to account for multiple results - #1706
Merged
Conversation
|
Review this PR in Hyponome for a side-by-side diff of the step-template JSON and any embedded scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The latest version of Grate is including two
grate.exefiles within GitHub Asset download. When executing on Windows, this caused an error.Results
When the user has selected the
Download Grateoption, this PR checks to see if multiple results were returned when searching for the executable and chooses the first one within the results.Before
When choosing
Download Grateoption and running on Windows, multiple files were found which caused it to follow a code path that was meant for when the naming convention hadnetin the name. This resulted in no executable being selected which failed the template.After
Added a different code path that checks for multiple results and chooses the first one in the array if it is encountered. The multiple files seem to only occur for Windows, but the code work for Linux as well. It is currently not packaging multile executables in the Linux version, so it was difficult to test.
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$Metamust haveExportedAtandOctopusVersionupdated$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to it