Update ERC20 Example + Eliminate Solc Warnings on Exports #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylus-sdk/src/abi/export.rs
Outdated
| @@ -40,6 +40,8 @@ pub fn print_abi<T: GenerateAbi>() { | |||
| println!(" * For more information, please see [The Stylus SDK](https://github.com/OffchainLabs/stylus-sdk-rs)."); | |||
| println!(" */"); | |||
| println!(); | |||
| println!("// SPDX-License-Identifier: TODO"); | |||
There was a problem hiding this comment.
We should either parse the toml for this or drop the line imo. Otherwise you're letting the consumer of the crate decide the license of the abi in a way.
There was a problem hiding this comment.
Makes sense, will drop this line
There was a problem hiding this comment.
Will do some investigation into parsing the toml to get rid of the pesky warning and use the right license here
rauljordan
commented
Feb 1, 2024
|
updated @rachel-bousfield , ty for looking it over |
…-sdk-rs into update-erc20-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the erc20 example to the latest Stylus patterns of using a library for programs, alongside .cargo config optimizations. It also fixes OffchainLabs/cargo-stylus#27, which was annoying when trying to do a json ABI export to users