Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit develop #152

Merged
merged 27 commits into from
Sep 16, 2024
Merged

Audit develop #152

merged 27 commits into from
Sep 16, 2024

Conversation

rory-ocl
Copy link
Contributor

@rory-ocl rory-ocl commented Aug 22, 2024 •
edited
Loading

Description

Merge audit changes into develop for next release.

Checklist

  • I have documented these changes where necessary.
  • I have read the DCO and ensured that these changes comply.
  • I assign this work under its open source licensing.

@rory-ocl rory-ocl marked this pull request as ready for review August 22, 2024 05:45
rauljordan
rauljordan previously approved these changes Aug 23, 2024
View reviewed changes
@rory-ocl
H-01 Deny unsupported func attrs in sol_interface!
bde7e9f
@rory-ocl
H-02 Deny u32 in selector id override
b3cb490
@rory-ocl
M-03 Prevent interfaces gathering previous funcs
fb63d77
@rory-ocl
M-04 Fix export-abi with no return types
a4f7d52
@rory-ocl
M-10 Fail unimplemented features in sol_interface!
6a53fa3
@rory-ocl
M-11 Pass all unused attrs through in #[external]
ed0b570 
Also removes support for `#[pure]`, `#[view]`, and `#[write]` attributes
since we can infer them from a func's arguments anyway.
@rory-ocl
M-05 Remove broken storage types and update docs
7d05e8a
@rory-ocl
N-09 Update copyright year
e628162
@rory-ocl
N-07 Fix typos in comments
fc6ba64
@rory-ocl
N-06 Remove outdated reference to EagerStorage
79293f6
@rory-ocl
N-03 Use main branch for license links
c2f1fcb
@rory-ocl
L-03 Fix some documentation
72d6677
@rory-ocl
L-05 Default to mini-alloc in sdk
591f581
@rory-ocl
M-01 Enforce mutability rules in func definitions
8126ed9
@rory-ocl
N-01 Renames for clarity
b030792 
Old names have still been included, but marked as deprecated for now.
@rory-ocl
N-02 Remove unmaintained wee-alloc crate
9107caa 
Non-wasm32 targets can simply use standard allocator.
@rory-ocl
N-05 Add len() to StorageArray
a97885b
@rory-ocl
L-01 Clarify usage of Call::new_in
3d2fd30 
This also fixes the feature flag for Call::new which should only be
available when the `reentrant` feature is enabled.
@rory-ocl
L-07 Remove unimplemented RawDeploy methods
9c56c8b
@rory-ocl
C-01 Clarify inheritance storage difference
e3be4b8
@rory-ocl
L-09 Don't allow constant keyword in interfaces
d0a42e7 
This keyword has been unsupported in solidity since 0.5.0.
@rory-ocl
L-10 Only allow external in sol_interface
6948349
@rory-ocl
N-10 Move TODOs to issue tracker
11cb2ae 
Some have been added to internal docs & some have been linked in the
code if the issue is outside of this project.
@rory-ocl
C-2 Clarify docs around override functions
edb84f5
@rory-ocl
H-2 Remove #[selector(id = ...)] completely
559982c
@rory-ocl
M-10 Error on inheritance in sol_interface!
3ca6140 
Not currently supported, will be considered in the future.
joshuacolvin0
joshuacolvin0 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rory-ocl rory-ocl merged commit 04a477e into develop Sep 16, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@rauljordan rauljordan rauljordan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rory-ocl @rauljordan @joshuacolvin0