Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .flush() and .clear() to RawCall #37

Merged
merged 8 commits into from
Sep 5, 2023
Merged

add .flush() and .clear() to RawCall #37

merged 8 commits into from
Sep 5, 2023

Conversation

joshuacolvin0
Copy link
Member

No description provided.

@joshuacolvin0 joshuacolvin0 marked this pull request as draft August 31, 2023 04:23
@joshuacolvin0 joshuacolvin0 marked this pull request as ready for review August 31, 2023 04:28
@hkalodner
Copy link

@cla-bot check

@cla-bot cla-bot bot added the s label Sep 1, 2023
@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

The cla-bot has been summoned, and re-checked this pull request!

rachel-bousfield
rachel-bousfield approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, renamed the methods, removed the maybe variants, and added a new CachePolicy type

@rachel-bousfield rachel-bousfield merged commit b401b50 into stylus Sep 5, 2023
8 checks passed
@rachel-bousfield rachel-bousfield deleted the call-flush branch September 5, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-bousfield rachel-bousfield rachel-bousfield approved these changes

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuacolvin0 @hkalodner @rachel-bousfield