account_code and account_code_size host I/Os #191

mikebenfield · 2024-01-05T17:54:18Z

Associated PRs:

cla-bot · 2024-01-05T17:54:36Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot · 2024-01-05T18:54:16Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot · 2024-01-05T19:06:43Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot · 2024-01-09T07:01:11Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot · 2024-01-09T19:08:20Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

cla-bot · 2024-01-09T19:11:20Z

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

codecov · 2024-01-09T19:38:15Z

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (c817c85) 55.07% compared to head (a2d9bb1) 38.04%.
Report is 1 commits behind head on stylus.

❗ Current head a2d9bb1 differs from pull request most recent head 5c9f1ee. Consider uploading reports for the commit 5c9f1ee to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           stylus     #191       +/-   ##
===========================================
- Coverage   55.07%   38.04%   -17.04%     
===========================================
  Files         222      282       +60     
  Lines       31219    43430    +12211     
===========================================
- Hits        17195    16521      -674     
- Misses      11552    25448    +13896     
+ Partials     2472     1461     -1011

rachel-bousfield

Nice work! Some changes we'll need to make for the economics and UX of these affordances

arbitrator/wasm-libraries/user-host-trait/src/lib.rs

arbitrator/arbutil/src/evm/api.rs

arbitrator/stylus/tests/evm-data/src/main.rs

rachel-bousfield · 2024-01-18T23:00:30Z

arbitrator/wasm-libraries/user-host-trait/src/lib.rs

+    fn account_code(&mut self, address: u32, dest: u32, size: u32) -> Result<(), Self::Err> {
+        self.buy_ink(HOSTIO_INK + EVM_API_INK)?;


Let's also require enough gas for size bytes and pass size to Geth, which should only copy up to that many

rachel-bousfield · 2024-01-18T23:34:44Z

arbitrator/wasm-libraries/user-host-trait/src/lib.rs

+    fn account_code_size(&mut self, address: u32) -> Result<u32, Self::Err> {
+        self.buy_ink(HOSTIO_INK + EVM_API_INK)?;


We should probably require a sentry for these or at the very least params.ExtcodeCopyBaseEIP150

I don't know what "sentry" means in this context.

In Ethereum a sentry is an amount of gas you must have, but needn't pay, to do something. You can use require_ink and require_gas to achieve this. It's useful in contexts where you're about to do work that might be expensive, or if you want to restrict the kinds of things one can do with a call stipend (another EVM concept: a small gas credit you get when transferring value but for which we only want nonmutating purchases)

rachel-bousfield · 2024-01-18T23:53:59Z

arbos/programs/api.go

+		cost := vm.WasmAccountTouchCost(evm.StateDB, address)
+		if !evm.StateDB.Empty(address) {
+			return evm.StateDB.GetCode(address), cost
+		}
+		return []byte{}, cost


We shouldn't charge a constant amount of gas for a linear amount of work.

Also no need to check if the account is empty (see vm.opExtCodeCopy in instructions.go)

mikebenfield · 2024-01-30T17:37:20Z

arbos/programs/api.go

+
+		metaCost := vm.WasmAccountTouchCost(evm.StateDB, address)
+		loadCost := 3 * am.WordsForBytes(params.MaxCodeSize)
+		sentry := am.SaturatingUAdd(metaCost, loadCost)


Is a saturating add really what is needed here? Wouldn't it actually be a problem if this overflowed?

mikebenfield · 2024-01-30T17:39:26Z

arbos/programs/native.go

-//export accountCodeHashImpl
-func accountCodeHashImpl(api usize, address bytes20, cost *u64) bytes32 {
+//export accountCodeSizeImpl
+func accountCodeSizeImpl(api usize, address bytes20, cost *u64) u32 {


This interface seems not quite ideal to me (and where a similar interface appears for other functions), since the cost parameter is used both to input the current amount of gas and to output the cost - why not two different parameters?

rachel-bousfield

Looks great!

mikebenfield force-pushed the code branch from 4ca9f27 to 9774b70 Compare January 9, 2024 07:01

mikebenfield force-pushed the code branch from 9774b70 to 27a03b1 Compare January 9, 2024 19:08

mikebenfield force-pushed the code branch from 27a03b1 to a2d9bb1 Compare January 9, 2024 19:11

mikebenfield force-pushed the code branch from a2d9bb1 to 85b1a2a Compare January 17, 2024 21:38

cla-bot bot added the s label Jan 17, 2024

This was referenced Jan 17, 2024

account_code checks OffchainLabs/stylus-contracts#27

Merged

Cargo.lock update OffchainLabs/stylus-sdk-bf#6

Merged

code, code_size hostios OffchainLabs/stylus-sdk-rs#94

Closed

Hostio code OffchainLabs/stylus-sdk-c#16

Closed

rachel-bousfield changed the title ~~draft account_code and account_code_size hostio~~ account_code and account_code_size host I/Os Jan 18, 2024

rachel-bousfield suggested changes Jan 18, 2024

View reviewed changes

This was referenced Jan 24, 2024

code, code_size hostios OffchainLabs/stylus-sdk-c#17

Merged

code, code_size hostios OffchainLabs/stylus-sdk-rs#95

Merged

mikebenfield force-pushed the code branch 2 times, most recently from e4540d9 to 5dc31eb Compare January 24, 2024 01:58

account_code and account_code_size hostio

9fba9f6

mikebenfield force-pushed the code branch from 5dc31eb to 9fba9f6 Compare January 24, 2024 02:02

rachel-bousfield added 6 commits January 25, 2024 22:14

Merge branch 'stylus' into code

522e2f0

improve pricing

f74606b

Merge remote-tracking branch 'stylus/stylus' into code

b9f43a4

reorder hostios

c21deff

improve pricing model

189e64e

remove double slicing

88a5560

more tests

5c9f1ee

mikebenfield commented Jan 30, 2024

View reviewed changes

rachel-bousfield approved these changes Jan 30, 2024

View reviewed changes

rachel-bousfield merged commit d4e30af into stylus Jan 30, 2024
8 checks passed

rachel-bousfield deleted the code branch January 30, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

account_code and account_code_size host I/Os #191

account_code and account_code_size host I/Os #191

mikebenfield commented Jan 5, 2024 •

edited

Loading

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 9, 2024

cla-bot bot commented Jan 9, 2024

cla-bot bot commented Jan 9, 2024

codecov bot commented Jan 9, 2024 •

edited

Loading

rachel-bousfield left a comment

rachel-bousfield Jan 18, 2024

rachel-bousfield Jan 18, 2024

mikebenfield Jan 19, 2024

rachel-bousfield Jan 19, 2024

rachel-bousfield Jan 18, 2024

mikebenfield Jan 30, 2024

mikebenfield Jan 30, 2024

rachel-bousfield left a comment

		fn account_code(&mut self, address: u32, dest: u32, size: u32) -> Result<(), Self::Err> {
		self.buy_ink(HOSTIO_INK + EVM_API_INK)?;

		fn account_code_size(&mut self, address: u32) -> Result<u32, Self::Err> {
		self.buy_ink(HOSTIO_INK + EVM_API_INK)?;

account_code and account_code_size host I/Os #191

account_code and account_code_size host I/Os #191

Conversation

mikebenfield commented Jan 5, 2024 • edited Loading

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 5, 2024

cla-bot bot commented Jan 9, 2024

cla-bot bot commented Jan 9, 2024

cla-bot bot commented Jan 9, 2024

codecov bot commented Jan 9, 2024 • edited Loading

Codecov Report

rachel-bousfield left a comment

Choose a reason for hiding this comment

rachel-bousfield Jan 18, 2024

Choose a reason for hiding this comment

rachel-bousfield Jan 18, 2024

Choose a reason for hiding this comment

mikebenfield Jan 19, 2024

Choose a reason for hiding this comment

rachel-bousfield Jan 19, 2024

Choose a reason for hiding this comment

rachel-bousfield Jan 18, 2024

Choose a reason for hiding this comment

mikebenfield Jan 30, 2024

Choose a reason for hiding this comment

mikebenfield Jan 30, 2024

Choose a reason for hiding this comment

rachel-bousfield left a comment

Choose a reason for hiding this comment

mikebenfield commented Jan 5, 2024 •

edited

Loading

codecov bot commented Jan 9, 2024 •

edited

Loading