release: 1.13.0 — get_multiple batches (api#7240) - #98
Merged
Conversation
Minor rather than patch, deliberately. The public signature is unchanged, so strict semver would call this a patch — but it materially changes how many HTTP requests a call makes, and a minor keeps it out of tight pins like ~=1.12.8 while staying available to ~=1.12. Anyone on a narrow pin opts in rather than being surprised by a changed request pattern. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA
test_package_version_helper_reads_the_project_version asserted the literal '1.12.8', so it failed on this release for a reason unrelated to what it guards. Its job is 'does the helper report the PROJECT version', not 'is the version 1.12.8'. Now reads the expected value from pyproject.toml, so it keeps testing the helper and stops needing a hand-edit every release. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog for the #97 fix, so it can be published.
Why minor, not patch
The public signature is unchanged, so strict semver says patch. But this materially changes how many HTTP requests a call makes, and a minor keeps it out of tight pins like
~=1.12.8while staying available to~=1.12. Anyone on a narrow pin opts in rather than being surprised by a changed request pattern.What ships
get_multiple()batches — up to 20 codes per request instead of one per code. Through this method the free plan was 50 code-reads a day; through the raw API it is 1,000.AsyncPricesResource.get_multiple(), which was worse —asyncio.gatherfanned out one request per code, which could also trip the 60-per-60s rate limit.Users' quota consumption drops. In their favour, no code change needed — but it is a behaviour change and the changelog says so plainly.
One test fixed along the way
test_package_version_helper_reads_the_project_versionasserted the literal"1.12.8", so it failed on this release for a reason unrelated to what it guards. Its job is "does the helper report the project version", not "is the version 1.12.8". It now reads the expected value frompyproject.toml— so it keeps testing the helper and stops needing a hand-edit every release.Verification
Live smoke on the merged fix, against production:
Publishing is triggered by a published GitHub Release, so merging this does not ship to PyPI on its own.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JKAExynd9zoKwt6rYA66EA