Serve favicon #47
Open
Serve favicon #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick change for serving a favicon from the tracker. Maybe not the most efficient code (and I know headers aren't proper -- didn't bother to differentiate between favicon.ico and favicon.png requests), but hopefully this is useful for someone else.
Why? If someone is using redirect_url, there are many unneeded 302s without this change. Most GUI torrent clients now of days query for favicon at the base URL (eg http://tracker.example.com/favicon.png), instead of http://example.com/favicon.png. Additionally, many clients won't then try the favicon on the base domain after the 302, so any type of caching on their client for the favicon also fails.
So let's just serve the favicon from tracker, what could go wrong ;)