feat: modernize Windows installer UI - #12970
Draft
huhuanming wants to merge 9 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nsis-duilib-uiplugin and versioned OneKey theme resourcesThe MIT plugin source, preview app, theme system, and NSIS demos live at https://github.com/huhuanming/nsis-duilib-ui.
Install and upgrade state flow
The integration now treats these five points as acceptance requirements:
upgradepage; scope and path are read-only.Changedirectory action.$INSTDIRafter electron-builder's hidden install-mode page has finished, so scope/elevation handling cannot overwrite it.Additional handling:
/allusersand/currentuserremain authoritative and skip the scope pageProgress and i18n
ResetProgressis the only operation allowed to lower progress, and is called explicitly before a new attemptenalias:bn,de,en-US,es,fr-FR,hi-IN,id,it-IT,ja-JP,ko-KR,pt,pt-BR,ru,th-TH,uk-UA,vi,zh-CN,zh-HK, andzh-TWGetUserDefaultUILanguageLANGID semantics rather than formatting locale; Portuguese and Chinese regional LANGIDs map to the correct variants, with English fallbackValidation
Local check limitation
yarn agent:check --profile commitwas invoked before commit. This worktree has no Yarnnode_modulesstate file, so Yarn stops before project checks withCouldn't find the node_modules state file. The focused native tests, NSIS demo/smoke, safe runtime flows, and real electron-builder/makensis compilation pass.The real product failure/uninstall callbacks were compile-validated rather than forced against an installed OneKey application. Runtime failure/uninstall behavior was exercised through the safe demos using the identical DLL, pages, and NSIS event contract.
Notes