Skip to content

use arch rather than hardcode x86_64 in espeak-ng-data paths - #732

Open
mcarans wants to merge 2 commits into
OoliteProject:masterfrom
mcarans:arch_x86_64
Open

use arch rather than hardcode x86_64 in espeak-ng-data paths#732
mcarans wants to merge 2 commits into
OoliteProject:masterfrom
mcarans:arch_x86_64

Conversation

@mcarans

@mcarans mcarans commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Basically does what's in this PR:
#557

@mcarans
mcarans requested review from oocube and phkb as code owners August 30, 2026 21:32
@mcarans mcarans changed the title arch x86_64 use arch rather than hardcode x86_64 in espeak-ng-data paths Aug 30, 2026
phkb
phkb previously approved these changes Aug 31, 2026
@mcarans

mcarans commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@oocube @LW-archlinux are either of you able to test this?

@LW-archlinux

Copy link
Copy Markdown

install_packages_root.sh is only called from test_builds.yaml and build-all.yaml which are in .github/worklows folder .
It can only be tested on systems with access to github CI, probably limited to github.com/OoliteProject/oolite and forks within the github ecosystem.
Archlinux espeak-ng package uses /usr/share/espeak-ng-data/ and this is the upstream default path so the change should work for archlinux systems with espeak-ng installed and running on github CI.

As for paths surrounded by double quotes : paths without spaces in them don't need them.
If double-quoting all paths in oolite sourcecode is desired/deemed necessary that should be clarified in a coding style document.
Does oolite have such a document ?

I think post_build.sh is called by meson install so it should affect all builds ?
I'll have to apply this PR to master to test if that poses issues , will try to do that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants