Fix all compiler warnings - #734
Open
mcarans wants to merge 2 commits into
Open
Conversation
wormhole warning was actually a bug
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
August 31, 2026 05:53
Contributor
|
Was this intended to fix warnings? Because when I compile I get this: Which looks like a PR I applied a few months ago (#534), only in reverse! |
Contributor
Author
|
@phkb hmm there were no warnings on Linux so I think Windows uses unsigned long long for NSUInteger while Linux uses unsigned long by the look of it. I wonder if there's a format specified that will work for both and why they use different types at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
../../src/Core/Entities/WormholeEntity.m:746:26: warning: implicit conversion from 'double' to 'NSUInteger' (aka 'unsigned long') changes value from 0.34 to 0 [-Wliteral-conversion]
746 | NSRange activity = { 0.34, 1.0 };
This one was actually a bug as 0.34 is rounded to 0!