maps: Basic leaflet map #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can your template stuff check the variable can_download_geojson ? Not every data page is guaranteed to have GeoJSON files, if there is a problem converting that. Apart from that, looks great as a first go - we can sort details of error handling later. |
odscjames
reviewed
Nov 1, 2022
This adds a basic leaflet map to the explore page. It currently loads and displays the generated spans and nodes.
odscjames
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6
This adds a basic leaflet map to the explore page. It currently loads and displays the generated spans and nodes.
I decided to run with leaflet as modern openlayers is a JS compilation nightmare, and we can use leaflet plugins if we do decide we want another projection (i.e. https://github.com/kartena/Proj4Leaflet)
I wasn't sure how much error handling or resilience to add, so it just fails and provides an error message if it can't load a layer from the geojson files.