Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map customisation #29

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Map customisation #29

merged 5 commits into from
Nov 17, 2022

Conversation

Lathrisk
Copy link
Contributor

@Lathrisk Lathrisk commented Nov 8, 2022 •
edited
Loading

@Lathrisk Lathrisk force-pushed the map-customisation branch 3 times, most recently from 51ec2d2 to 405afdb Compare November 11, 2022 16:10
@odscjames odscjames changed the base branch from live to ng November 15, 2022 15:18
@Lathrisk Lathrisk marked this pull request as ready for review November 16, 2022 16:01
Jared Parnell added 4 commits November 16, 2022 16:06
maps: Provide 7 colours for network styles
564363a 
This provides 7 colours which are used in sequence for unique networks. These colours are repeated once the number exceeds 7.
And adds a legend
map: Update select labels
3f77b64
maps: Add more features to the colour coding
0644f5e 
This adds logic and fields that can be selected for colour coding. The fields will take the pretty field name and attach either the field value or  if the field does not exist
maps: Catch unloaded data
6c798c3 
If a single geojson file is uploaded this will prevent errors and return an console log that one of the files could not be loaded. This is less elegant than switching which layers to create but that route has added complexity. A good future improvement
codemacabre
codemacabre previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@codemacabre codemacabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work!

@odscjames odscjames merged commit 1802861 into ng Nov 17, 2022
@odscjames odscjames deleted the map-customisation branch November 17, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemacabre codemacabre codemacabre approved these changes

@odscjames odscjames Awaiting requested review from odscjames

Assignees

@Lathrisk Lathrisk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lathrisk @codemacabre @odscjames