-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WKT for node locations and span routes #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once #259 is merged, then |
rhiaro
previously approved these changes
May 8, 2023
Merging without further review since the only change in a516512 was to resolve a conflict in the changelog. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
TO-DO
pre-commit
command inmanage.py
Node.location
andSpan.route
to explain use of WKT for CSV filesMerge checklist
./manage.py pre-commit
to update derivative schema files, reference documentation and examplesIf there are changes to
network-schema.json
,network-package-schema.json
,reference/publication_formats/json.md
,reference/publication_formats/geojson.md
orguidance/publication.md#how-to-publish-large-networks
, update the relevant manually authored examples:examples/json/
:network-package.json
api-response.json
multiple-networks.json
network-embedded.json
network-separate-endpoints.json
network-separate-files.json
nodes-endpoint.json
spans-endpoint.json
examples/geojson/
:api-response.geojson
multiple-networks.geojson
If you used a validation keyword, type or format that is not already used in the schema:
network-package-invalid.json
.If you added a normative rule that is not encoded in JSON Schema:
network-package-additional-checks.json
.If there are changes to
examples/geojson/nodes.geojson
orexamples/geojson/spans.geojson
, check and update the data use examples:examples/leaflet/leaflet.ipynb
examples/qgis/geojson.qgs