Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] POC Ability to choose non-system user to execute a payload #1396

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

@savacano28 savacano28 commented Sep 9, 2024

Proposed changes

POC

  • Add elevation required into payload formes
  • Add elevation required into assetJobAgent
  • Add credentials to link to install agent on windows

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this Sep 9, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@savacano28 savacano28 linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.44%. Comparing base (6922917) to head (802f5f0).

Files with missing lines Patch % Lines
.../openbas/rest/payload/form/PayloadCreateInput.java 0.00% 1 Missing ⚠️
.../openbas/rest/payload/form/PayloadUpdateInput.java 0.00% 1 Missing ⚠️
.../openbas/rest/payload/form/PayloadUpsertInput.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1396      +/-   ##
============================================
+ Coverage     31.42%   31.44%   +0.01%     
- Complexity     1407     1409       +2     
============================================
  Files           525      526       +1     
  Lines         13678    13686       +8     
  Branches        807      807              
============================================
+ Hits           4298     4303       +5     
- Misses         9182     9185       +3     
  Partials        198      198              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/1179-poc branch 2 times, most recently from 91fdfd2 to dc4c7b5 Compare September 10, 2024 14:52
@savacano28 savacano28 added the do not merge Do not merge this PR until this tag will be removed label Sep 11, 2024
@savacano28 savacano28 changed the title [backend] Add elevation required attribute [backend] POC Ability to choose non-system user to execute a payload Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this PR until this tag will be removed filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to choose a service account on linux
1 participant