[frontend] Upgrade SheetJS (xlsx) because of vulnerability #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
filigran team
|
Shouldn't we use something like this : https://www.npmjs.com/package/@e965/xlsx?activeTab=readme ? Using the cdn means no renovate :/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
=========================================
Coverage 33.15% 33.15%
Complexity 1599 1599
=========================================
Files 561 561
Lines 14646 14646
Branches 895 895
=========================================
Hits 4856 4856
Misses 9559 9559
Partials 231 231 ☔ View full report in Codecov by Sentry. |
guillaumejparis
force-pushed
the
snyk/high_xlsx
branch
from
1b7d8f6
to
7dfc53d
Compare
guillaumejparis
force-pushed
the
snyk/high_xlsx
branch
from
b934916
to
1f7a0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk report high vulnerability.
We need to change the cdn where we download it : SheetJS/sheetjs#2822 (comment)