Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link target and using PROJECT_SOURCE_DIR #10

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

doug1234
Copy link
Contributor

A couple of fixed to be more correct and fix our build. We should only link against what is actually needed and PROJECT_SOURCE_DIR is the correct directory to use so it does not break when the cmake file is nested.

@doug1234
Copy link
Contributor Author

Not getting these errors when I build locally with the RTPS_Udp. Is there a build flag that should be passed to make the CI build happy.

@iguessthislldo
Copy link
Member

iguessthislldo commented Sep 18, 2023

It looks like RapidJSON is there when OpenDDS is built, but for some reason it's missing when OpenDDS is restored from the cache. @simpsont-oci, @mitza-oci, any ideas? Are the submodules getting initialized?

@simpsont-oci
Copy link
Contributor

simpsont-oci commented Sep 18, 2023

Hmm... the rapidjson files were never included in the cache, as they're not part of what's built by OpenDDS. I suppose the CI steps for initializing the submodules should be included regardless of whether the cache hits or misses?

@mitza-oci
Copy link
Member

Re-test after #11 is merged

@doug1234
Copy link
Contributor Author

Looks like it is still failing...

@simpsont-oci
Copy link
Contributor

Looks like it is still failing...

You'll need to merge master or rebase your branch to pick up the CI changes.

@doug1234
Copy link
Contributor Author

Ah right... looking good now. Hopefully it can be merged.

@iguessthislldo iguessthislldo merged commit fd0739a into OpenDDS:master Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants