-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with 3.25 #9
Conversation
This doesn't seem to be building because it is using the head of master instead of the 3.25 tag for the CI process. That is annoying. |
It's both, some CI jobs use latest-release and others use master. |
It isn't going to build both with 3.25 and master due to recent changes. Should I change this PR to work with master? Is there going to be a new official release soon? It would seem to me to be smoother to just submodule opendds at a particular version which we know works but I guess you don't want to do it that way. |
I think we can emulate the raw configuration values. OpenDDS/OpenDDS#4255 |
Kicking off new builds. |
This PR is building with 3.25 but still not building with master. Is there a tweak I should make that can get it to build with both or should I make changes to build with master and move on? |
Let me take another crack at it. I didn't account for assignment in that way. I should be able to replicate it with a unit test. |
Looks like it built and failed again. Are there more variables I should remove for openddw or is this something that needs to change in opendds? |
There were more changes from OpenDDS/OpenDDS#4272 |
Looks like things are passing now. Can this update be merged? |
No description provided.