Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with 3.25 #9

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Build with 3.25 #9

merged 1 commit into from
Sep 18, 2023

Conversation

doug1234
Copy link
Contributor

@doug1234 doug1234 commented Sep 5, 2023

No description provided.

@doug1234
Copy link
Contributor Author

doug1234 commented Sep 5, 2023

This doesn't seem to be building because it is using the head of master instead of the 3.25 tag for the CI process. That is annoying.

@mitza-oci
Copy link
Member

This doesn't seem to be building because it is using the head of master instead of the 3.25 tag for the CI process. That is annoying.

It's both, some CI jobs use latest-release and others use master.
Assuming we want to keep that in place, it would need to use preprocessor conditionals to build either way (or OpenDDS would need to change)

@doug1234
Copy link
Contributor Author

doug1234 commented Sep 5, 2023

It isn't going to build both with 3.25 and master due to recent changes. Should I change this PR to work with master? Is there going to be a new official release soon?

It would seem to me to be smoother to just submodule opendds at a particular version which we know works but I guess you don't want to do it that way.

@jrw972
Copy link
Contributor

jrw972 commented Sep 5, 2023

I think we can emulate the raw configuration values. OpenDDS/OpenDDS#4255

@jrw972
Copy link
Contributor

jrw972 commented Sep 7, 2023

Kicking off new builds.

@doug1234
Copy link
Contributor Author

This PR is building with 3.25 but still not building with master. Is there a tweak I should make that can get it to build with both or should I make changes to build with master and move on?

@jrw972
Copy link
Contributor

jrw972 commented Sep 11, 2023

Let me take another crack at it. I didn't account for assignment in that way. I should be able to replicate it with a unit test.

@jrw972
Copy link
Contributor

jrw972 commented Sep 12, 2023

OpenDDS/OpenDDS#4270

@jrw972
Copy link
Contributor

jrw972 commented Sep 13, 2023

OpenDDS/OpenDDS#4272

@doug1234
Copy link
Contributor Author

doug1234 commented Sep 14, 2023

Looks like it built and failed again. Are there more variables I should remove for openddw or is this something that needs to change in opendds?

@jrw972
Copy link
Contributor

jrw972 commented Sep 14, 2023

Looks like it built and failed again. Are there more variables I should remove for openddw or is this something that needs to change in opendds?

There were more changes from OpenDDS/OpenDDS#4272

@doug1234
Copy link
Contributor Author

Looks like things are passing now. Can this update be merged?

@simpsont-oci simpsont-oci merged commit b4fb147 into OpenDDS:master Sep 18, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants