fix: Delete the duplicate button #2844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2844 +/- ##
=============================================
+ Coverage 56.01% 56.12% +0.11%
- Complexity 8197 8547 +350
=============================================
Files 2103 2140 +37
Lines 89017 90538 +1521
Branches 6560 6717 +157
=============================================
+ Hits 49853 50803 +950
- Misses 37446 37979 +533
- Partials 1718 1756 +38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ion-segment itself already manages a group of buttons (ion-segment-button elements). By removing the redundant wrapper, it could simplify the DOM structure, making code cleaner.