Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to block until the LCD update has completed if the LCD_DISPLAY_NOW is set #705

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

jeremypoulter
Copy link
Collaborator

This fixes issues during firmware update where the incomming data also blocks the CPU and the LCD was not being updated, especcially over Ethernet as the data is received much faster than WiFI.

Fixes #597

…AY_NOW` is set

This fixes issues during firmware update where the incomming data also blocks the CPU and the LCD was not being updated, especcially over Ethernet as the data is received much faster than WiFI
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Test Results

36 tests  ±0   36 ✔️ ±0   0s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit e2d36f1. ± Comparison against base commit 888c5c4.

♻️ This comment has been updated with latest results.

@jeremypoulter jeremypoulter marked this pull request as ready for review July 27, 2023 21:01
@glynhudson glynhudson merged commit 8ab2855 into master Aug 30, 2023
19 checks passed
@glynhudson glynhudson deleted the jeremypoulter/issue597 branch August 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCD not refreshed correctly with fw update
2 participants