Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pydantic v2 #226

Merged
merged 3 commits into from
Sep 1, 2023
Merged

test pydantic v2 #226

merged 3 commits into from
Sep 1, 2023

Conversation

mikemhenry
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b611a5) 99.12% compared to head (e050553) 99.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          36       36           
  Lines        1831     1838    +7     
=======================================
+ Hits         1815     1822    +7     
  Misses         16       16           

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry mikemhenry marked this pull request as ready for review August 30, 2023 20:22
@mikemhenry
Copy link
Contributor Author

Like OpenFreeEnergy/openfe#541 should I add another CI job to the matrix that checks to make sure things work with the older version of pydantic?

@richardjgowers
Copy link
Contributor

@mikemhenry yup

@mikemhenry mikemhenry marked this pull request as draft August 31, 2023 20:34
@mikemhenry mikemhenry marked this pull request as ready for review September 1, 2023 21:36
@mikemhenry mikemhenry enabled auto-merge (squash) September 1, 2023 21:36
@mikemhenry mikemhenry merged commit 34cf380 into main Sep 1, 2023
9 checks passed
@mikemhenry mikemhenry deleted the feat/support_pydantic_v1_v2_for_real branch September 1, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants