Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see if py311 works okay #508

Merged
merged 3 commits into from
Aug 2, 2023
Merged

see if py311 works okay #508

merged 3 commits into from
Aug 2, 2023

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Aug 1, 2023

Developers certificate of origin

@mikemhenry
Copy link
Contributor Author

Inspired by #507

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e67dc6) 91.81% compared to head (e727936) 91.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         110      110           
  Lines        6681     6681           
=======================================
  Hits         6134     6134           
  Misses        547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 3.11 works. I vote to include it in our testing matrix. Also means that wasn't the problem in #507.

@IAlibay IAlibay enabled auto-merge August 1, 2023 19:39
@IAlibay
Copy link
Member

IAlibay commented Aug 1, 2023

O we probably should limit Macos to a single runner but if this auto merges first we can do it later

@IAlibay IAlibay disabled auto-merge August 1, 2023 19:40
@mikemhenry
Copy link
Contributor Author

Okay if we only want to run a job on OSX, which python version do we want it to be? I can do that on this PR.

@mikemhenry
Copy link
Contributor Author

Maybe just the latest? So python 3.11 on osx but skip the others? Or do we want to keep the oldest and the newest and just skip 3.10?

@IAlibay
Copy link
Member

IAlibay commented Aug 1, 2023

Maybe just the latest? So python 3.11 on osx but skip the others? Or do we want to keep the oldest and the newest and just skip 3.10?

3.11 only is fine, that's what folks will pick up on a clean install.

@IAlibay IAlibay enabled auto-merge August 2, 2023 14:20
@mikemhenry
Copy link
Contributor Author

Got all the branch checks setup now as well

@IAlibay IAlibay merged commit 73556db into main Aug 2, 2023
7 checks passed
@IAlibay IAlibay deleted the feat/add_py_311_testing branch August 2, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants