Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add flaky markers to flaky tests on macOS GitHub actions runners #509

Closed
wants to merge 2 commits into from

Conversation

dwhswenson
Copy link
Member

This PR will add flaky markers to tests that we see being flaky on macOS in GitHub action. I'm leaning toward just keeping this PR going for a bit (I expect there's more than one flaky test in this part of the code; I just haven't tracked which ones tend to be problematic). However, if people really want to have a separate PR for each one, we can do that too.

Developers certificate of origin

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (25fb327) 91.29% compared to head (03dd28f) 91.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files         116      116           
  Lines        7056     7057    +1     
=======================================
+ Hits         6442     6443    +1     
  Misses        614      614           
Files Changed Coverage Δ
...e/tests/utils/test_atommapping_network_plotting.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member

IAlibay commented Jan 16, 2024

@dwhswenson this has sat around for a while and it doesn't seem like we've been suffering from the issue anymore, do you mind if I close this PR?

@richardjgowers
Copy link
Contributor

I think this flaky marker doesn't work if the runners are crashing anyway(?)

@mikemhenry mikemhenry deleted the flaky-macos-tests branch April 12, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants