Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the ability to pass user charges #524

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Check the ability to pass user charges #524

merged 4 commits into from
Aug 18, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 16, 2023

Adds a test that both manually checks charge assignment (good for us) and that user supplied charges will get all the way through to the HTF (good for users).

Developers certificate of origin

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (ff7bb16) 92.01% compared to head (901b2ef) 92.07%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   92.01%   92.07%   +0.06%     
==========================================
  Files         113      113              
  Lines        6850     6904      +54     
==========================================
+ Hits         6303     6357      +54     
  Misses        547      547              
Files Changed Coverage Δ
...tests/protocols/test_openmm_equil_rfe_protocols.py 90.90% <100.00%> (+1.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Aug 17, 2023

Anyone got any ideas why RTD is broken here?

@mikemhenry
Copy link
Contributor

mikemhenry commented Aug 17, 2023

AttributeError: 'TocTree' object has no attribute 'get_toctree_ancestors'

Smells like we need to add a pin, looks like the issue is here pydata/pydata-sphinx-theme#1412

I will give CI a bump since that might be all we need (since a new release was cut hours ago)

@mikemhenry
Copy link
Contributor

@IAlibay you should be good now :)

@IAlibay
Copy link
Member Author

IAlibay commented Aug 17, 2023

cheers @mikemhenry !

@richardjgowers richardjgowers merged commit 28bd902 into main Aug 18, 2023
7 checks passed
@richardjgowers richardjgowers deleted the user-charges branch August 18, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants